From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wGkgJNF4BWb3jRkAWB0awg (envelope-from ) for ; Thu, 28 Mar 2024 10:04:01 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=BBhGbtdv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8E48F1E0C0; Thu, 28 Mar 2024 10:04:01 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7CF2D1E030 for ; Thu, 28 Mar 2024 10:03:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F0FE3858D33 for ; Thu, 28 Mar 2024 14:03:59 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 101D83858D1E for ; Thu, 28 Mar 2024 14:03:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 101D83858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 101D83858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711634617; cv=none; b=tw3w5GCC26EzW51KXw4IkNlyduKlt/XQ5E17nyUtkiX5NZe5A6f67joUifpqn4WYJDrasPO30e3N/4YvzQoawfLVCsp8B80uWnXI5/D+M7dVcOjuV4wyJjTuCNa86hKSn6NwKY93z86wcn7gzHISk4JZEVA3JFD24FzlPbi80hE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711634617; c=relaxed/simple; bh=g2WDV4aG77zX6auxPV36lGLTpsq6M7fRwyrCi33EGB8=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=wJbvyZKU5bg/jAj4BlmKmJY361Tm+L2KtStfU9RXLq/PzLCO+OKy3iGSndH4DUEpCwbSwUp9XR75OZSiX7rsi2EKHtwo92QymaIJ17AJ6xnAfZ8ETw/4K3Ezra8P25nk1CYt6qE+5uvxPW5Qh/v8zTOY7DDdlWDq34qar74js1A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpqLv-0003Ra-5c; Thu, 28 Mar 2024 10:03:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OQ5I6FZFYLBN6iS7WSYUEfQqc7PL2usT2vdiAwxaJyw=; b=BBhGbtdvGq/5 111ZOAKotG/5/jEGscQpm9FU2gHc8q8pIU+Pl5aqOIHNRapCAZ/9bwbPxhbXWdBRoPzXsKSLXbgkc RfxVWFBa1p4zyIKWE03VRcD4p6REwoUvEqrryQuNJjpTp1n5e2LA4UYvtH86CVi3NGS/Ay486PWJF T0gRiy1tyRecPw1kTgSWkFTI6h/thJxGmhhCAZNIK2HHIbv7R7OD3FQy2sxycn2lxW7s0P0hQGiW+ c96TtZgFSFSlN3cKKjXY6jtDdKQgdnx6gxa7+f/tjaj6EVxM8jLt0NMzxLm67m8yFgR7cp2lDrdC/ c7mE9dxVLQ35xZvNtXYgdQ==; Date: Thu, 28 Mar 2024 16:03:31 +0200 Message-Id: <86plvefo7g.fsf@gnu.org> From: Eli Zaretskii To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org, JiniSusan.George@amd.com, tom@tromey.com In-Reply-To: <20240328120528.30382-10-abdul.b.ijaz@intel.com> (message from Abdul Basit Ijaz on Thu, 28 Mar 2024 13:05:27 +0100) Subject: Re: [PATCH v6 09/10] gdb, mi: Skip trampoline functions for the -stack-list-arguments command. References: <20240328120528.30382-1-abdul.b.ijaz@intel.com> <20240328120528.30382-10-abdul.b.ijaz@intel.com> X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > From: Abdul Basit Ijaz > Cc: abdul.b.ijaz@intel.com, > JiniSusan.George@amd.com, > tom@tromey.com, > eliz@gnu.org > Date: Thu, 28 Mar 2024 13:05:27 +0100 > > gdb/doc/gdb.texinfo | 4 ++++ > gdb/mi/mi-cmd-stack.c | 7 +++++++ > gdb/testsuite/gdb.mi/mi-func-trampoline.exp | 13 ++++++++++--- > 3 files changed, 21 insertions(+), 3 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 90221e9b9c1..6b2f40c906c 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -35183,6 +35183,10 @@ variable object is updated, @value{GDBN} makes sure that the > thread/frame combination the variable object is bound to still exists, > and re-evaluates the variable object in context of that thread/frame. > > +If the option @code{skip-trampoline-functions} is set for the > +@code{-stack-list-arguments}, @value{GDBN} will not show trampoline > +functions in the stack. > + > The following is the complete set of @sc{gdb/mi} operations defined to > access this functionality: The documentation part is approved, thanks. Reviewed-By: Eli Zaretskii