From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qZbVHQX7M2qjjw0AWB0awg (envelope-from ) for ; Thu, 18 Jun 2026 10:04:53 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=jmKj9RlU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 753111E098; Thu, 18 Jun 2026 10:04:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 80D491E024 for ; Thu, 18 Jun 2026 10:04:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 530F74BA2E33 for ; Thu, 18 Jun 2026 14:04:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 530F74BA2E33 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=jmKj9RlU Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3844F4BA23C2 for ; Thu, 18 Jun 2026 14:03:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3844F4BA23C2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3844F4BA23C2 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781791426; cv=none; b=FLFL9mlQnwo9DJO6AWN2Dzvm7fsAD22/1FLyjSmBK43IHdKAVm2hTovfqOxaJMQN+ClDnnH0NTY1RFi867Nhhci5FbBgxTsMYdRgSxrTukTl1s3FCglTS76benPSSxVQOvAA3e+1aEw2QrZUeNN1nQMW09RcTqyzbn7c2yR4040= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1781791426; c=relaxed/simple; bh=5LWzdXkGt+BuHEnXat1N5mePLe59o+HzEdGwp+cDIKA=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=nq/nqUMZfLzD1Yy7LRrovY474pRDj1ylWfdXyRK1cDdDzjnTV8IBqapvF9Oh7CSLoxrs16fLeGvC3QMJ7UGa83aM5/lPpxkPIe/0ijTeLjpiIAb90MqPpaKXgfscIoq8L9+9KcHY8mCh95aHL+L54KIYl9AuGbAXrd6OoGOMbfM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=jmKj9RlU DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3844F4BA23C2 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1waDLN-0002N9-NO; Thu, 18 Jun 2026 10:03:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oydiFdePaC0B3O8L1ze0JAGXVI9VdhOhcZObODpJygY=; b=jmKj9RlU7hM5 M6FsxjgKVa0hI90F2iIoszBHjEZobFvBIhQYmN2LruN33ZfMO1X11XsrfeEy/YCVJS3QSL54hCC8w DjB34+3wdwVKcun0IVPzXKFYktKlFTLb4rib/OPraR4lIY7bQ270L8lsx0cMEfca3gTfhbd1QC4oH Lkkf16J/DCfG1yH4ToCmm79zdCC/5v8ckX5VI0+vnp2/LFeu0BIjo6r2gI/FZUaXF269h2Y9q+6Y8 0YAP6I3i3iIyi/NVzhjc0YjVtnp7WpTC3mRe2LWl0iOmClW8shFvY8ahM9dv6kd4FF+S80+FvsRoh n2LenX496MTTIs9UpdQsyQ==; Date: Thu, 18 Jun 2026 17:03:41 +0300 Message-Id: <86pl1ogd36.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org In-Reply-To: <20260618133818.55460-1-tdevries@suse.de> (message from Tom de Vries on Thu, 18 Jun 2026 15:38:09 +0200) Subject: Re: [PATCH 0/9] [gdb] More whitespace fixes References: <20260618133818.55460-1-tdevries@suse.de> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tom de Vries > Date: Thu, 18 Jun 2026 15:38:09 +0200 > > I came across the trailing-whitespace hook here ( > https://github.com/pre-commit/pre-commit-hooks ) and tried it out: > ... > # Out-of-the-box pre-commit hooks. > - repo: https://github.com/pre-commit/pre-commit-hooks > rev: v6.0.0 > hooks: > - id: trailing-whitespace > files: '^(gdb|gdbserver|gdbsupport)/.*$' > exclude: 'ChangeLog' > args: [--chars," \t"] > ... > > The args field is necessary to stop it removing ^L. > > The result is: > ... > $ pre-commit run trailing-whitespace --all-files > trim trailing whitespace................................................Failed > - hook id: trailing-whitespace > - exit code: 1 > - files were modified by this hook > > Fixing gdbsupport/Makefile.in > Fixing gdb/config/djgpp/fnchange.lst > Fixing gdb/doc/annotate.texinfo > Fixing gdb/doc/stack_frame.txt > Fixing gdb/exc_request.defs > Fixing gdb/doc/refcard.tex > Fixing gdb/gdb-gdb.gdb.in > Fixing gdb/configure.tgt > ... > > This made me look again at our homegrown whitespace check, and I found that it > recognizes a set of clean files that doesn't include the above files. > > This patch series: > - in check-whitespace-pre-commit.py, adds a todo list of files which are not > yet clean, enabling complete checking for all other files, and > - reduces the todo list with each following patch. > > Tom de Vries (9): > [gdb] Increase clean range in check-whitespace-pre-commit.py > [gdb] Fix leftover conflict marker in gdb/config/djgpp/README > [gdb] Fix new blank line at EOF in a few scripts > [gdb] Fix new blank line at EOF in a few xml files > [gdb] Ignore whitespace in imported file gdb/exc_request.defs > [gdb] Fix trailing whitespace in some files > [gdb] Ignore trailing whitespace in gdb/gdb-gdb.gdb.in > [gdb] Fix trailing whitespace in annotate.texinfo > [gdb] Fix trailing whitespace in refcard.tex > > .pre-commit-config.yaml | 1 + > gdb/.gitattributes | 6 +++++ > gdb/config/djgpp/.gitattributes | 3 +++ > gdb/config/djgpp/djcheck.sh | 1 - > gdb/config/djgpp/fnchange.lst | 2 +- > gdb/configure.tgt | 6 ++--- > gdb/contrib/ari/create-web-ari-in-src.sh | 1 - > gdb/contrib/ari/gdb_ari.sh | 1 - > gdb/contrib/check-whitespace-pre-commit.py | 13 +++++++---- > gdb/doc/annotate.texinfo | 8 +++---- > gdb/doc/refcard.tex | 26 +++++++++++----------- > gdb/doc/stack_frame.txt | 2 +- > gdb/features/aarch64-pauth.xml | 1 - > gdb/features/library-list-aix.dtd | 1 - > gdb/features/s390-core64.xml | 1 - > gdb/features/sparc/sparc32-cp0.xml | 1 - > gdb/features/sparc/sparc32-fpu.xml | 1 - > gdb/features/sparc/sparc64-cp0.xml | 1 - > gdb/features/sparc/sparc64-fpu.xml | 1 - > 19 files changed, 41 insertions(+), 36 deletions(-) > create mode 100644 gdb/config/djgpp/.gitattributes Seems to be obvious fixes to me, no? Thanks.