From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AnP+K+RplWqfQhcAWB0awg (envelope-from ) for ; Mon, 31 Aug 2026 07:47:48 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=VLpz3zO9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9DF191E166; Mon, 31 Aug 2026 07:47:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8CE851E033 for ; Mon, 31 Aug 2026 07:47:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E5C824BA7994 for ; Mon, 31 Aug 2026 11:47:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E5C824BA7994 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=VLpz3zO9 Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C9F454BA2E25 for ; Mon, 31 Aug 2026 11:47:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9F454BA2E25 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C9F454BA2E25 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788176842; cv=none; b=t7GyoDE2SboYVVuz8guwNOdQmhwu4QrZofVOSfkXV5onIQqG8yya5Pokfz0mVAADFv43MIMdReFVfxRcJivWoHS77RTipGKIMHn6HVqJAztU5OcCcb0DMEZaLuJadF9RM1Q4o6HIhsQVkwN8df9BLpKIXeRi1WhNTMzlFxUBjWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788176842; c=relaxed/simple; bh=ROO+k0eIqhr034iruxPZw1tYYA04K5F4mOqhx5TmQZo=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=RDxXpkfSUomIeEQB4hS/9J4gC0pzhIPi6UtwUlcmalpmInQDfT9iwM3V+gB2G3ltzTyH+UqIf+b6CAOni8PgDoJyuJWvzSvwQPHZBfGizoPkBHpF7Kn0HMDTtBgCJ+pG7/wF4Ba2aKUXfavq35tCuEQb3m9rgrdp7eh/ptz8cic= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=VLpz3zO9 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9F454BA2E25 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x10Tt-0008EW-7K; Mon, 31 Aug 2026 07:47:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Tgo8AezlyTh4OrPv3iruNd5tuQQkwUjjiDHlkas20To=; b=VLpz3zO9eW6Q OZ9FcshMJ9dn6FbOwiwtwfaH/LWL78y/1KwtLzwRaZGAmTj+ubnudac5QRb4kjdlqW02/9csVurZ0 NdrvGKX5UG4GAEp1zUxr8u+TGL6nwEroNwDBauRtvDKZqDrqMvEz9Mdd8jbASJPc8rQUZoUIfo1B5 9B+wFxYnE7ACAbUwKx7Um0EaxwZYH+N9RFoUnDpMXEMw+BZUb24aLd9TMJB8nhteJGDSpWykCY2jg /zaCFOoeylZz0OAi9fvOhNSpbKi+uuPoqUntRdjbN48q9YeBx+Ql2PqcThZIBbBVl+bFeHo9MJyLE bWEvq/IgWQucjggQoKnnLg==; Date: Mon, 31 Aug 2026 14:47:08 +0300 Message-Id: <86pkyy8qbn.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org, DJ Delorie In-Reply-To: <20260831100826.3521717-1-tdevries@suse.de> (message from Tom de Vries on Mon, 31 Aug 2026 12:08:26 +0200) Subject: Re: [PATCH] [gdb/config/djgpp] Make djcheck.sh and djconfig.sh shellcheck-clean References: <20260831100826.3521717-1-tdevries@suse.de> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tom de Vries > Date: Mon, 31 Aug 2026 12:08:26 +0200 > > Make gdb/config/djgpp/{djcheck.sh,djconfig.sh} shellcheck-clean: > - add missing quotes > - add "|| exit 1" after cd > - use printf instead of echo -n > - use $() > - disable SC2016 for "configure --prefix='${DJDIR}' assuming ${DJDIR} is > indeed not meant to be expanded What's the problem with `foo` that you replace it with $() everywhere? I don't remember, but there's a risk that DJGPP ports of Bash might not support the latter.