Re: [PATCH v3 08/10] Support software single step on ARM in GDBServer.

Yao Qi
2015-11-27T15:15:49Z

On 27/11/15 13:45, Antoine Tremblay wrote:
>
> And I don't think it's good to have it in 2 calls, so I will have the
> same collect_register_unsigned_field...

If so, let us keep collect_register_unsigned field.
>
> Thus this refactoring would not simplify the patch and IMHO would create
> some inconsistency why are we using regcache in some place for no
> apparent gain while all the rest uses frame.

That is what I want to avoid... for the software single step routines
in two sides (GDB and GDBserver), I don't want to see that regcache is
used in one side while frame is used in the other side. regcache should
be used in both sides.

>
> In light of this, I plan to keep it as is unless there's an objection ?

Sorry, I don't like the patch as is. I plan to change gdbarch method
software_single_step to something like this,

F:VEC (CORE_ADDR) *:software_single_step:struct regcache *regcache:regcache

it returns a set of address on which GDB can insert software single step
breakpoint.

--
Yao (é½å°§)