From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32579 invoked by alias); 25 Nov 2015 17:01:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32562 invoked by uid 89); 25 Nov 2015 17:01:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 25 Nov 2015 17:01:16 +0000 Received: by padhx2 with SMTP id hx2so62716489pad.1 for ; Wed, 25 Nov 2015 09:01:14 -0800 (PST) X-Received: by 10.66.194.198 with SMTP id hy6mr26002251pac.34.1448470874280; Wed, 25 Nov 2015 09:01:14 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id eg5sm22497203pac.30.2015.11.25.09.01.12 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 25 Nov 2015 09:01:13 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v3 07/10] Share some ARM target dependant code from GDB with GDBServer. References: <1448287968-12907-1-git-send-email-antoine.tremblay@ericsson.com> <1448287968-12907-8-git-send-email-antoine.tremblay@ericsson.com> Date: Wed, 25 Nov 2015 17:01:00 -0000 In-Reply-To: <1448287968-12907-8-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Mon, 23 Nov 2015 09:12:45 -0500") Message-ID: <86oaeixbca.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00525.txt.bz2 Antoine Tremblay writes: > gdb/ChangeLog: > > * arch/arm.c (bitcount): Move from arm-tdep.c. > (condition_true): Likewise. > * arch/arm.h (Instruction Definitions): Move form arm-tdep.h. > (condition_true): Move defenition from arm-tdep.h. > (bitcount): Likewise. > * arm-tdep.c (condition_true): Move to arch/arm.c. > (bitcount): Likewise. > * arm-tdep.h (Instruction Definitions): Move to arch/arm.h. > * arm-wince-tdep.c: Include arch/arm.h. > * armnbsd-tdep.c: Likewise. Looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)