From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114726 invoked by alias); 18 Jan 2016 10:35:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114697 invoked by uid 89); 18 Jan 2016 10:35:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=sigstepexp, UD:sigstep.exp, sigstep.exp, r11 X-HELO: mail-pf0-f193.google.com Received: from mail-pf0-f193.google.com (HELO mail-pf0-f193.google.com) (209.85.192.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 18 Jan 2016 10:34:59 +0000 Received: by mail-pf0-f193.google.com with SMTP id 65so11582593pff.2 for ; Mon, 18 Jan 2016 02:34:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=bIQU2AhmE9p3B+70zHdpp4AyC9LGwZngpt1SYb2mYpQ=; b=B/ZxthCgibl7e2PshXW4P/BSEPaZ4aBBGUh1IdQFJXbAaRGL9spnv8kfCFp+mV68uQ /B/HP1sJ1bA1HQLQBVbTN8pFJWuU+c7WFodrNQkpdIOd9p4vrpPThUl07cjJgrLic4dF 5R/jqzQYlMB72RuQhMmxPsuG/sHT0FQLrxqjQgwHa6H+FPglu2+gX1i/f3JUdHD6Vnpk rBsefDoR4XqvhKvJ+tp7AnvN54wGdFaRavHF7ASoMPZ9Wuu3OeYZT/WhICcA7op/O+4w P6j4RbVthqWIA/kES6qshc/q9r3LIP8plwjSdetxzRIrIRJoEwMEa0aPDv6kkSCUufrL Zzaw== X-Gm-Message-State: ALoCoQkwKCBBt4jx0cg0BmAiTf8QYd4sEDDL3+4w/5Xh0pA36q5HHAoh39/HKMFsgpgQqtnuCUmpFHa3L4oEcdFi3CoVHWNr7Q== X-Received: by 10.98.10.81 with SMTP id s78mr33325685pfi.119.1453113297778; Mon, 18 Jan 2016 02:34:57 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id n27sm32959864pfb.53.2016.01.18.02.34.55 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 18 Jan 2016 02:34:56 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH v8 3/7] Refactor arm_software_single_step to use regcache References: <1450361684-29536-1-git-send-email-antoine.tremblay@ericsson.com> <1450361684-29536-4-git-send-email-antoine.tremblay@ericsson.com> Date: Mon, 18 Jan 2016 10:35:00 -0000 In-Reply-To: <1450361684-29536-4-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Thu, 17 Dec 2015 09:14:40 -0500") Message-ID: <86oacjtbue.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00369.txt.bz2 Antoine Tremblay writes: > This patch is in preparation for software single step support on ARM in > GDBServer. It refactors arm_*_software_single_step and sub-functions to > use regcache instead of frame to access registers so that the code can be > shared more easily between GDB and GDBServer. > > Note also that since the intention is at some point to get rid of frame > completely in that function, memory reads have also been replaced by > read_memory_unsigned_integer rather than get_frame_memory_unsigned. > > No regressions, tested on ubuntu 14.04 ARMv7 and x86. > With gdbserver-{native,extended} / { -marm -mthumb } As a record, this patch causes regressions at least in gdb.base/sigstep.exp, (gdb) PASS: gdb.base/sigstep.exp: continue to handler, si+advance in handle= r, step from handler: advance in handler step^M 39 } /* handler */^M 1: x/i $pc^M =3D> 0x8740 : sub sp, r11, #0^M (gdb) step^M ^M Program received signal SIGSEGV, Segmentation fault.^M setitimer () at ../sysdeps/unix/syscall-template.S:81^M 81 ../sysdeps/unix/syscall-template.S: No such file or directory.^M 1: x/i $pc^M =3D> 0xb6eff9c0 : push {r7}^M (gdb) FAIL: gdb.base/sigstep.exp: continue to handler, si+advance in handle= r, step from handler: leave handler Could you take a look at it? --=20 Yao (=E9=BD=90=E5=B0=A7)