From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126745 invoked by alias); 31 Mar 2016 10:51:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126733 invoked by uid 89); 31 Mar 2016 10:51:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:806, par X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 31 Mar 2016 10:51:44 +0000 Received: by mail-pa0-f42.google.com with SMTP id zm5so64034073pac.0 for ; Thu, 31 Mar 2016 03:51:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=O3ssvRQeUC8zhWFI0O6ORIEiuyJBJTVqWA4O9+c/d54=; b=Pj3sdrNmvbeiw+kzqciF0IbuHdQvcdCnVnVisKTsxe5t/gTBujXgrT1xEYuLgnMPI6 eZa5JWZYSiTc8fLms7pjmBYsneu3eFX7XbogjyVgGiyU/Ql7qhQg3Eo/39QblVL2kHGp rmzcH/aIsii4h8vAckwjO7QQXEoNa+Cibk1rFxqYzpI0vyVLJmkODJd4gVZTIBIcStb2 uXyPBlb+xuRJG9H0vtXS6U/NtF5YsmnjEfTDCQRH1VqOf6/+yhyQrjkPE10UopSOXVbS eFWc1anino4lGZdPlnk+4nUBsBQymr2GIpVU5id3hfyHjakke0RzwdBNrS24cKT+h+c5 p/dw== X-Gm-Message-State: AD7BkJIHXNp7K5FsbYE64Ql8ISrBSPl5QzaskKfJixucwI2x3cyWa8H7e36rGqXqI+zEKA== X-Received: by 10.66.152.231 with SMTP id vb7mr20997111pab.132.1459421502997; Thu, 31 Mar 2016 03:51:42 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id e6sm12569491pfj.71.2016.03.31.03.51.40 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 31 Mar 2016 03:51:42 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: , Par Olsson Subject: Re: [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag References: <1459351018-23718-1-git-send-email-simon.marchi@ericsson.com> Date: Thu, 31 Mar 2016 10:51:00 -0000 In-Reply-To: <1459351018-23718-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 30 Mar 2016 11:16:57 -0400") Message-ID: <86oa9urkcm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00588.txt.bz2 Simon Marchi writes: > I am sending this fix on behalf of Par Olsson, as a follow-up of this > one: > > https://www.sourceware.org/ml/gdb-patches/2015-10/msg00196.html Hi Simon, The patch in the url above is to change 'enabled' field to uint32_t, so I guess you got the patch below from Par Olsson off list? The reason I ask this is that I find the author doesn't have the copyright assignment. We can take it as a tiny patch, if no one has objections. >=20=20 > static int > +write_inferior_int8 (CORE_ADDR symaddr, int8_t val) > +{ > + return write_inferior_memory (symaddr, (unsigned char *) &val, sizeof = (val)); This line is too long. > +} The patch itself is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)