From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86156 invoked by alias); 15 Apr 2016 14:41:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86141 invoked by uid 89); 15 Apr 2016 14:41:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 15 Apr 2016 14:41:32 +0000 Received: by mail-pa0-f41.google.com with SMTP id zm5so56004696pac.0 for ; Fri, 15 Apr 2016 07:41:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=j4rxgwE8fjrX6zUGaFC4/UQFRS/mv0s63KMB21yluA4=; b=UiYFrw3wMMwTVGCkbMA3yW92cnXH/UnfX/7o4stHZ2FPl8p7iqYQEyuW+p9xHYEziJ XIxBcvUPhKU+pUcHm5uFC3Cq/XhfLdRL2aq5KAAdnUsZNWU5QkHUIDT6MWB68Vts7pFX llIT/Ec4HT6C1D0bqosx+2MWMUdA7khCkU/VMjTybKAuUienak4kUwRoz+bxisjmSGsh atZN3SYzS0loYDM8cGJI1MB2LRVcf3/QeshZKv6B2fNyk3v0MHJGo6DvTQR3SVEbJ/VS 4ILg/FM87czGBWSSsbP1wC88SZqw5j6gi7u5x4M6sXoUOEVXHe9kXk3ZUhqt5rUaXYdu 8uEQ== X-Gm-Message-State: AOPr4FVetZtk6GQt1P5lBOQG/ZwWVcc3WGPiNWsE2oZ5m/PIOBpmbRwV4VT+sYricPQb4w== X-Received: by 10.66.175.110 with SMTP id bz14mr30004917pac.41.1460731290495; Fri, 15 Apr 2016 07:41:30 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 62sm65287048pfk.83.2016.04.15.07.41.27 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 15 Apr 2016 07:41:29 -0700 (PDT) From: Yao Qi To: Bernhard Heckel Cc: qiyaoltc@gmail.com, gdb-patches@sourceware.org, brobecker@adacore.com Subject: Re: [PATCH V2 2/2] fortran: Testsuite, fix different type naming across compilers. References: <1460724297-23523-1-git-send-email-bernhard.heckel@intel.com> <1460724297-23523-3-git-send-email-bernhard.heckel@intel.com> Date: Fri, 15 Apr 2016 14:41:00 -0000 In-Reply-To: <1460724297-23523-3-git-send-email-bernhard.heckel@intel.com> (Bernhard Heckel's message of "Fri, 15 Apr 2016 14:44:57 +0200") Message-ID: <86oa9bkk8m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00359.txt.bz2 Bernhard Heckel writes: > -# Depending on the compiler version being used, the name of the 4-byte i= nteger > -# and real types can be printed differently. For instance, gfortran-4.1= uses > -# "int4" whereas gfortran-4.3 uses "int(kind=3D4)". > -set int4 "(int4|integer\\(kind=3D4\\))" > -set real4 "(real4|real\\(kind=3D4\\))" > - > -gdb_test "ptype p" "type =3D Type bar\r\n *${int4} :: c\r\n *${real4} ::= d\r\n *End Type bar" > +gdb_test "ptype p" "type =3D Type bar\r\n *$int :: c\r\n *$real :: d\r\n= *End Type bar" > + > +proc fortran_int4 {} { > + if {[test_compiler_info {gcc-4-[012]-*}]} { > + return "int4" > + } elseif {[test_compiler_info {gcc-*}]} { > + return "integer\\(kind=3D4\\)" > + } elseif {[test_compiler_info {icc-*}]} { > + return "INTEGER\\(4\\)" > + } else { > + return "unknown" > + } > +} > + > + > +if ![info exists int4] then { > + set int4 [fortran_int4] > +} Why do you prefer to define these info? In each test, we can do set int4 [fortran_int4], IMO, that is much cleaner than your current approach (define int4 globally in lib/fortran.exp and use it everywhere). --=20 Yao (=E9=BD=90=E5=B0=A7)