Re: [PATCH v4 1/3] Factor out "Detaching from program" message printing

Yao Qi
2016-06-17T11:31:38Z

Pedro Alves <palves@redhat.com> writes:

> Several targets have a copy of the same code that prints
>
> "Detaching from program ..."
>
> in their target_detach implementation. Factor that out to a common
> function.
>
> (For now, I left the couple targets that print this a bit differently
> alone. Maybe this could be further pulled out into infcmd.c. If we
> did that, and those targets want to continue printing differently,
> this new function could be converted to a target method.)
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * darwin-nat.c (darwin_detach): Use target_announce_detach.
> * inf-ptrace.c (inf_ptrace_detach): Likewise.
> * nto-procfs.c (procfs_detach): Likewise.
> * remote.c (remote_detach_1): Likewise.
> * target.c (target_announce_detach): New function.
> * target.h (target_announce_detach): New declaration.

Patch is good to me.

--
Yao (齐尧)