From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-138953-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16880 invoked by alias); 9 May 2017 14:21:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16852 invoked by uid 89); 9 May 2017 14:21:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=
X-HELO: mail-wr0-f195.google.com
Received: from mail-wr0-f195.google.com (HELO mail-wr0-f195.google.com) (209.85.128.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 May 2017 14:21:45 +0000
Received: by mail-wr0-f195.google.com with SMTP id 6so493374wrb.1        for <gdb-patches@sourceware.org>; Tue, 09 May 2017 07:21:47 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to         :message-id:user-agent:mime-version:content-transfer-encoding;        bh=RsceSkHUbpDnprFpqRmECue8ePQIYzLXkZvTWVHywaU=;        b=O9giooTAv650aAwqIRA0a1akP/8xa3WllVWPcHcux7VeoAgJTaHjTrlIBAJoLMR/if         v6OLTaWi5LkDfy8FKDl7RjdX60Cg3+GxOUSvY8knuGvnrirtz7ajB6v1PVGy8WE0Zru8         jkn8WBInj51HbflgKaAKhwGqmbVnQMPlNck6IF/seJSnvt21wfPbkPN8GkAWxZ0jl0gz         ATlox1x3mAljLwsQ/DEe9zVCGR2mu3gKruFSQSY3Qy9xQmWmVSpQn+wggiul2ot6Jiyc         /IQJWgc0L4ahpZu1AiXMsqXBr4ekqkTyFo45aWzwXE0oWuf8fhIVOVyUENcc2jLdDbBx         4yYw==
X-Gm-Message-State: AODbwcCHVf7BIwGGUrGLvQueFacotZUxrzFxQmZNpDfiO6g6l0geigbt	gM0R/PnzWJ3PgjxE
X-Received: by 10.28.17.21 with SMTP id 21mr316426wmr.83.1494339705835;        Tue, 09 May 2017 07:21:45 -0700 (PDT)
Received: from E107787-LIN ([194.214.185.158])        by smtp.gmail.com with ESMTPSA id 136sm313760wmx.25.2017.05.09.07.21.44        (version=TLS1_2 cipher=AES128-SHA bits=128/128);        Tue, 09 May 2017 07:21:45 -0700 (PDT)
From: Yao Qi <qiyaoltc@gmail.com>
To: Stafford Horne <shorne@gmail.com>
Cc: GDB patches <gdb-patches@sourceware.org>,  Openrisc <openrisc@lists.librecores.org>, 	Franck Jullien <franck.jullien@gmail.com>
Subject: Re: [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
References: <cover.1493038197.git.shorne@gmail.com>	<cover.1493038197.git.shorne@gmail.com>	<dbd35ae7e8f9ca8db89dd14b81119d3eb50afb98.1493038197.git.shorne@gmail.com>
Date: Tue, 09 May 2017 14:21:00 -0000
In-Reply-To: <dbd35ae7e8f9ca8db89dd14b81119d3eb50afb98.1493038197.git.shorne@gmail.com>	(Stafford Horne's message of "Mon, 24 Apr 2017 21:52:50 +0900")
Message-ID: <86o9v2t8js.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2017-05/txt/msg00213.txt.bz2

Stafford Horne <shorne@gmail.com> writes:
>=20=20
>        if (reggroup =3D=3D general_reggroup)
>  	return general_p;
> +
> +      if (strcmp (reg->group, reggroup_name (reggroup)) =3D=3D 0)
> +	return 1;
> +
>      }

I read the patch again, and find that we can replace the whole block in
"if (reg !=3D NULL && reg->group !=3D NULL)" with the code this patch adds,
like this,

  if (reg !=3D NULL && reg->group !=3D NULL
      && (strcmp (reg->group, reggroup_name (reggroup)) =3D=3D 0))
     return 1;

--=20
Yao (=E9=BD=90=E5=B0=A7)