Re: [PATCH] [testsuite] Pass -lpthread in libs

Simon Marchi
2017-11-22T15:30:33Z

On 2017-11-22 10:17, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> I am seeing:
>>
>> gdb compile failed, .../info-os.c:51:1: warning: control reaches end
>> of non-void function [-Wreturn-type]
>>
>> with clang-6.0. Once I fix it, the test passes for me.
>
> Yes, it is another patch in my tree, to be posted.
>
>>
>> Instead of passing -lpthread directly, it would probably be better to
>> pass the
>> "pthreads" option, like this:
>
> OK, how about the patch below?
>
> --
> Yao (é½å°§)
>
> From c7392e6f937bf342daee99dfd5bcc6daf91af417 Mon Sep 17 00:00:00 2001
> From: Yao Qi <yao.qi@linaro.org>
> Date: Fri, 17 Nov 2017 13:04:10 +0000
> Subject: [PATCH] [testsuite] Pass pthreads in prepare_for_testing
>
> "pthreads" in the right flag to pass in prepare_for_testing to linker,
> instead of additional_flags. Without this patch, the test case can't
> be
> complied by clang.
>
> gdb compile failed, clang: warning: -lpthread: 'linker' input unused
>
> gdb/testsuite:
>
> 2017-11-22 Yao Qi <yao.qi@linaro.org>
>
> * gdb.base/info-os.exp: Pass pthreads.
> * gdb.multi/multi-attach.exp: Likewise.
>
> diff --git a/gdb/testsuite/gdb.base/info-os.exp
> b/gdb/testsuite/gdb.base/info-os.exp
> index 574da26..3267eec 100644
> --- a/gdb/testsuite/gdb.base/info-os.exp
> +++ b/gdb/testsuite/gdb.base/info-os.exp
> @@ -28,7 +28,7 @@ if [gdb_skip_xml_test] then {
> }
>
> # Compile test program.
> -if { [prepare_for_testing "failed to prepare" $testfile $srcfile
> {debug additional_flags=-lpthread}] } {
> +if { [prepare_for_testing "failed to prepare" $testfile $srcfile
> {debug pthreads}] } {
> fail "cannot compile test program"
> return -1
> }
> diff --git a/gdb/testsuite/gdb.multi/multi-attach.exp
> b/gdb/testsuite/gdb.multi/multi-attach.exp
> index 9397f85..0e54b4f 100644
> --- a/gdb/testsuite/gdb.multi/multi-attach.exp
> +++ b/gdb/testsuite/gdb.multi/multi-attach.exp
> @@ -23,7 +23,7 @@ if {![can_spawn_for_attach]} {
> return 0
> }
>
> -if {[prepare_for_testing "failed to prepare" $testfile $srcfile
> {debug additional_flags=-lpthread}]} {
> +if {[prepare_for_testing "failed to prepare" $testfile $srcfile
> {debug pthreads}]} {
> return -1
> }

LGTM.