From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xAJWKVKwEWW0vRwAWB0awg (envelope-from ) for ; Mon, 25 Sep 2023 12:07:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=qXchvMnC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9FE961E0C3; Mon, 25 Sep 2023 12:07:46 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9345E1E092 for ; Mon, 25 Sep 2023 12:07:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E2627385C6DB for ; Mon, 25 Sep 2023 16:07:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E2627385C6DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1695658063; bh=w7tgBVU4ZoyFonMusRpvcnj5ngb92v4bVia6epl6tzk=; h=References:To:Cc:Subject:Date:In-reply-to:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=qXchvMnC88pj3cAiXVlsx3C5ccfgfNBYMN/cRtDvXfB/t8e/oHdRnsZJ5Tyd4LU/9 Yc8ikZXsg1rBQXNnJK3dBb1QmQZ8YWCdX9kjbwr3mmODsu4EYLRFebd3mkfDdyelvQ kbOxB39cP7WT2Or95A6dtmGseehUKluuIwPU+FoU= Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by sourceware.org (Postfix) with ESMTPS id 740A03858CDA; Mon, 25 Sep 2023 16:07:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 740A03858CDA Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4RvSSR3v44z9sQy; Mon, 25 Sep 2023 18:07:19 +0200 (CEST) References: <20230925153247.908901-1-arsen@aarsen.me> <20230925153247.908901-3-arsen@aarsen.me> To: Andreas Schwab Cc: Arsen =?utf-8?Q?Arsenovi=C4=87?= via Binutils , gdb-patches@sourceware.org, Bruno Haible , Iain Sandoe Subject: Re: [PATCH 2/2] *: suppress xgettext 0.22 charset name error Date: Mon, 25 Sep 2023 17:55:20 +0200 In-reply-to: Message-ID: <86o7hqz16y.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_INFOUSMEBIZ, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?utf-8?q?Arsen_Arsenovi=C4=87_via_Gdb-patches?= Reply-To: Arsen =?utf-8?Q?Arsenovi=C4=87?= Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Andreas Schwab writes: > On Sep 25 2023, Arsen Arsenovi=C4=87 via Binutils wrote: > >> libctf/ChangeLog: >> >> * po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot >> temporary file to suppress xgettext checking charset names. > > There is no po/Make-in in libctf. Seems to have been an error when I was filling the changelog entries. The libctf changelog should be: * Makefile.am (SUBDIRS): Define to empty to suppress Automake stating 'configure.ac: error: AM_GNU_GETTEXT used but SUBDIRS not defined' ... which also covers your latter comment. > >> diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am >> index 00524e9a566..43aa670faf4 100644 >> --- a/gdbsupport/Makefile.am >> +++ b/gdbsupport/Makefile.am >> @@ -19,6 +19,7 @@ >>=20=20 >> AUTOMAKE_OPTIONS =3D no-dist foreign >> ACLOCAL_AMFLAGS =3D -I . -I ../config >> +SUBDIRS =3D >>=20=20 >> AM_CPPFLAGS =3D -I$(srcdir)/../include -I$(srcdir)/../gdb \ >> -I../gnulib/import -I$(srcdir)/../gnulib/import \ > > Spurious change. This has the same rationale as the libctf change above.=20 >> diff --git a/libctf/Makefile.am b/libctf/Makefile.am >> index b1dbc2f6ba4..8c9f623f58c 100644 >> --- a/libctf/Makefile.am >> +++ b/libctf/Makefile.am >> @@ -17,6 +17,8 @@ >> # . >> # >>=20=20 >> +SUBDIRS =3D=20 >> + >> ACLOCAL_AMFLAGS =3D -I .. -I ../config -I ../bfd >>=20=20 >> AUTOMAKE_OPTIONS =3D dejagnu foreign info-in-builddir no-texinfo.tex > > Likewise. These directories utilize ZW_GNU_GETTEXT_SISTER_DIR to get information about where gettext is despite never having any translations of their own, leading to the Automake warning above.=20 Apologies for the ChangeLog confusion, it must've been late when I was splitting and merging commits, and so I mislabeled and mismerged some changes. I can split this patch into two if you agree, and fix the libctf ChangeLog entry. Thanks, have a lovely day. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZRGwNV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosSTwVgA/0pqYkb3mq84TS4ljlfFUdlKlMAOZc+YVSgQ Fr+InEzsAQDnvy/qMU4tnGFaKna5JrmqxgRADPfr/JAZp+dFgXZDDw== =S5bG -----END PGP SIGNATURE----- --=-=-=--