From: Mark Kettenis <kettenis@chello.nl>
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc] 16 bit real-mode for the i386
Date: Thu, 29 Aug 2002 15:36:00 -0000 [thread overview]
Message-ID: <86n0r5pacf.fsf@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: Andrew Cagney's message of "Thu, 29 Aug 2002 16:30:11 -0400"
Andrew Cagney <ac131313@ges.redhat.com> writes:
> Hello,
>
> The attached modifies i386-tdep.c so that there is a ``set i386
> real-mode'' command (doco to go).
>
> When real-mode is enabled, GDB computes the ``20 bit'' ``stop address''
> (aka PC but not to be confused with $pc ... :-) from both the $cs and
> $pc registers. That way, core GDB sees a cannonical PC address that
> (regardless of $cs) will match a ``20 bit'' breakpoint address.
>
> Thoughts?
Looks OK to me. Just two nits: could you consider
s/CS_REGNUM/I386_CS_REGNUM/? And I believe the GNU coding standards
say that one shouldn't introduce unecessary whitespace. Therefore I
have some problems with the extra newlines you're introducing.
Are you planning to add this before we cut the branch? I'm a little
uncomfortable with adding any new features just before doing so.
Mark
next prev parent reply other threads:[~2002-08-29 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-29 13:33 Andrew Cagney
2002-08-29 14:37 ` Daniel Jacobowitz
2002-08-29 14:46 ` Kevin Buettner
2002-08-29 14:52 ` Daniel Jacobowitz
2002-08-29 14:46 ` Andrew Cagney
2002-08-30 12:31 ` Eli Zaretskii
2002-08-29 15:36 ` Mark Kettenis [this message]
2002-08-30 12:47 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86n0r5pacf.fsf@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox