From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-126965-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24598 invoked by alias); 26 Oct 2015 00:17:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 24588 invoked by uid 89); 26 Oct 2015 00:17:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pa0-f53.google.com
Received: from mail-pa0-f53.google.com (HELO mail-pa0-f53.google.com) (209.85.220.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 26 Oct 2015 00:17:36 +0000
Received: by pacfv9 with SMTP id fv9so177256707pac.3        for <gdb-patches@sourceware.org>; Sun, 25 Oct 2015 17:17:34 -0700 (PDT)
X-Received: by 10.66.102.38 with SMTP id fl6mr18924806pab.49.1445818654708;        Sun, 25 Oct 2015 17:17:34 -0700 (PDT)
Received: from sspiff.org (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50])        by smtp.gmail.com with ESMTPSA id kv9sm30555024pab.39.2015.10.25.17.17.32        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Sun, 25 Oct 2015 17:17:34 -0700 (PDT)
Received: by sspiff.org (sSMTP sendmail emulation); Mon, 26 Oct 2015 00:17:48 +0000
From: Doug Evans <xdje42@gmail.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>
Cc: Pedro Alves <palves@redhat.com>,  GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] [D] Remove search_parents parameter from d_lookup_symbol_imports
References: <CABOHX+dAvESSm0gHL4vvwX4JuoZhiy+uac6hSirQ6c35Da0_SQ@mail.gmail.com>	<56250F4F.7050908@redhat.com>	<CABOHX+ew_AL+kXWHOJKGNQ=aP=fQwva7Kkywo_1UC+OcJntyeQ@mail.gmail.com>
Date: Mon, 26 Oct 2015 03:47:00 -0000
In-Reply-To: <CABOHX+ew_AL+kXWHOJKGNQ=aP=fQwva7Kkywo_1UC+OcJntyeQ@mail.gmail.com>	(Iain Buclaw's message of "Fri, 23 Oct 2015 22:35:29 +0200")
Message-ID: <86mvv6cwk3.fsf@sspiff.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2015-10/txt/msg00529.txt.bz2

> On 19 October 2015 at 17:42, Pedro Alves <palves@redhat.com> wrote:
>>
>> On 10/11/2015 01:01 PM, Iain Buclaw wrote:
>> > Whilst looking at part one, a moment of insight came to me and I
>> > realized this code is completely nonsensical.
>> >
>> > For a start, when importing modules, you don't gain access to all
>> > parent packages of the given module.
>> >
>> > To add some confusion, even the comment was wrong.  It doesn't even
>> > cater for the example given (it's d_lookup_symbol_module that walks up
>> > each block scope).
>> >
>> > I feel embarrassed it didn't come to me before. :-)
>>
>> The usual penance is writing test cases.  :-)
>>
>
> It helps if there is a compiler readily available to compile said
> tests.  However, there likely is a way to get around this that I'm not
> aware of. (Skip certain tests if a compiler doesn't exist?  ;-)
>
> With this patch though, it's all dead code.  Hard to write a test for
> something that is unreachable.

Would the testsuite's DWARF assembler help here?
IOW, write the test in DWARF, not D.