From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10832 invoked by alias); 21 Apr 2017 16:41:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10794 invoked by uid 89); 21 Apr 2017 16:41:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-spam-relays-external:74.125.82.66, H*RU:74.125.82.66 X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Apr 2017 16:41:03 +0000 Received: by mail-wm0-f66.google.com with SMTP id z129so5894684wmb.1 for ; Fri, 21 Apr 2017 09:41:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=kwxbMJPZdvDjP36ZmQSQx3ysJDO9g7hwsviz12WKpXc=; b=IPu9cNeFD+GgYPXnkif4uJh/JVDbcycMIfk78oYAqkcbblBFr3/6Ct/GYprF1jiSOC ORadMb5ZBvgXNF7gT8oh+7paMzixWrwfRLPu2O6uksX6v0Ojr7A7zPz8R55LL9GpuZB4 4oJaOeFwSm6PvcLI12uv6ePEPNxgitPVu0LhB/cZWefTNKaiF7ZmHgotsl1MBw/FzUzX JRxkkgoMv5kVwdT9sllh/JCgAKc7YfxGdZjiiiq7HmoxNyPKNZTmTwNr86puP0dbj9/Z u5/1L7hFF81oMpeLChR1Daf634LR/U2z6fZBSZSNUc1286oG2Ktve9HzVDdULCQB1qV7 COzA== X-Gm-Message-State: AN3rC/6LazReS3Z3x2fg1THa+Ljk+ad7wxurV413VCCo/lUeLG4RYjtO uAHLQKAX541eYQCe X-Received: by 10.28.113.73 with SMTP id m70mr8975379wmc.12.1492789248653; Fri, 21 Apr 2017 08:40:48 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id p60sm12094141wrc.66.2017.04.21.08.40.47 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 21 Apr 2017 08:40:48 -0700 (PDT) From: Yao Qi To: Tim Wiederhake Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, brobecker@adacore.com Subject: Re: [PATCH v2 7/8] Python: Move and rename gdb.BtraceFunction References: <1492771786-26372-1-git-send-email-tim.wiederhake@intel.com> <1492771786-26372-8-git-send-email-tim.wiederhake@intel.com> Date: Fri, 21 Apr 2017 16:41:00 -0000 In-Reply-To: <1492771786-26372-8-git-send-email-tim.wiederhake@intel.com> (Tim Wiederhake's message of "Fri, 21 Apr 2017 12:49:45 +0200") Message-ID: <86mvb9zs3n.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00614.txt.bz2 Tim Wiederhake writes: > Remove gdb.BtraceFunctionCall and replace by gdb.FunctionSegment. Additi= onally, > rename prev_segment and next_segment to prev and next. > > 2017-04-21 Tim Wiederhake > > gdb/ChangeLog: > * python/py-record-btrace.c (BTPY_REQUIRE_VALID_CALL, btpy_call_type): > Remove. > (btrace_func_from_recpy_func): New function. > (btpy_call_new, btpy_number, btpy_hash, btpy_richcompare): Remove. > (btpy_call_level, btpy_call_symbol, btpy_call_instructions, > btpy_call_up, btpy_call_prev_sibling, btpy_call_next_sibling): Rename to= ... > (recpy_bt_func_level, recpy_bt_func_symbol, recpy_bt_func_instructions, > recpy_bt_func_up, recpy_bt_func_prev, recpy_bt_func_next): This. > Also, use new helper functions. > (btpy_list_item): Use new helper functions. > (recpy_bt_function_call_history): Use new type name. > (btpy_call_getset): Remove. > (gdbpy_initialize_btrace): Remove code to initialize > gdb.BtraceFunctionCall. > * python/py-record-btrace.h (recpy_bt_func_number, recpy_btb_func_level, > recpy_btb_func_symbol, recpy_bt_func_instructions, recpy_bt_func_up, > recpy_bt_func_prev, recpy_bt_func_next): New export. > * python/py-record.c (recpy_func_type): New static object. > (recpy_func_new, recpy_func_level, recpy_func_symbol, > recpy_func_instructions, recpy_func_up, recpy_func_prev, > recpy_func_next): New function. > (recpy_element_hash, recpy_element_richcompare): Updated comment. > (recpy_func_getset): New static object. > (gdbpy_initialize_record): Add code to initialize gdb.RecordInstruction. > * python/py-record.h (recpy_func_type, recpy_func_new): New export. > > gdb/doc/ChangeLog: > * python.texi (Recording in Python): Replace gdb.BtraceFunction with > gdb.RecordFunctionSegment. Rename prev_sibling and next_sibling to > prev and next. > > gdb/testsuite/ChangeLog: > * gdb.python/py-record-btrace.exp: Rename prev_sibling and next_sibling > to prev and next. LGTM. --=20 Yao (=E9=BD=90=E5=B0=A7)