From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] gdbserver: redo stepping over breakpoint that was on top of a permanent breakpoint
Date: Tue, 24 Feb 2015 12:25:00 -0000 [thread overview]
Message-ID: <86lhjnxzrs.fsf@gmail.com> (raw)
In-Reply-To: <1424723261-15719-1-git-send-email-palves@redhat.com> (Pedro Alves's message of "Mon, 23 Feb 2015 20:27:41 +0000")
Pedro Alves <palves@redhat.com> writes:
> + unsigned int increment_pc;
> +
> + if (the_low_target.breakpoint_len > the_low_target.decr_pc_after_break)
> + increment_pc = the_low_target.breakpoint_len;
> + else
> + increment_pc = the_low_target.decr_pc_after_break;
AFAICS, the_low_target.breakpoint_len is greater or equal to
the_low_target.decr_pc_after_break. Why don't we use .breakpoint_len
instead? The code is correct, however, the comparison here leads me to
think under what situation .breakpoint_len is less than .decr_pc_after_break.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-02-24 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 20:27 Pedro Alves
2015-02-24 12:25 ` Yao Qi [this message]
2015-02-26 19:01 ` Pedro Alves
2015-09-24 10:43 ` Yao Qi
2015-09-24 11:39 ` Antoine Tremblay
2015-09-24 13:21 ` Yao Qi
2015-09-24 16:43 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lhjnxzrs.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox