From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28977 invoked by alias); 26 Feb 2016 14:14:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28958 invoked by uid 89); 26 Feb 2016 14:14:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pa0-f67.google.com Received: from mail-pa0-f67.google.com (HELO mail-pa0-f67.google.com) (209.85.220.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 26 Feb 2016 14:14:54 +0000 Received: by mail-pa0-f67.google.com with SMTP id yy13so4544969pab.1 for ; Fri, 26 Feb 2016 06:14:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Pa4CyBTD70f6GdLCUKJh6uiRkBPfJLXKKUonWKITeBE=; b=hXcx1O3SS1LPGRVxFtWuUKvSz+JMxS0sw++b9NHzUY3WzNBHezHFZlmlNQ67FDXr+6 vhscV1c8ckreM/APpOqSdZIdBhLbznlGA7IwfBU3LWt7rIJuBxMJSmKfZMWbALEqApCC 2xIsVHvniwOoUZk03A9f0fg6PpXhh6vHfubeZDEFfFGCqW7w2pl0chsvMUP5Kd/drDDi lpihQv40qUQi59M7Y2ej7JJn847ejBhZo3qFwuRtF31K9E48naLDRVsTZ39XRNLXvo1o 6uef2Bn9r96s0QOCZRPEgUSS+b1Ar0RJ9R1ouXPaES9KL1UfXFzLurJFir/eYGYHku7R wlPw== X-Gm-Message-State: AD7BkJLXHvorXCn1LvcMPm4WQu7zOn4AcrogsQLLamXEt1qrdoCHRkHQW4PTIfSdNGORjw== X-Received: by 10.66.118.7 with SMTP id ki7mr2346912pab.153.1456496092572; Fri, 26 Feb 2016 06:14:52 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 16sm19841509pfk.28.2016.02.26.06.14.49 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 26 Feb 2016 06:14:51 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: , Subject: Re: [PATCH v7] Enable tracing of pseudo-registers on ARM References: <1456491775-29750-1-git-send-email-antoine.tremblay@ericsson.com> Date: Fri, 26 Feb 2016 14:14:00 -0000 In-Reply-To: <1456491775-29750-1-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Fri, 26 Feb 2016 08:02:55 -0500") Message-ID: <86lh67blt9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00856.txt.bz2 Antoine Tremblay writes: > gdb/testsuite/ChangeLog: > > * gdb.trace/tracefile-pseudo-reg.c: Include arm_neon.h if on arm. arm_neon.h is not included now, but stdint.h is included. > (main): Add a register variable and a tracepoint label. > * gdb.trace/tracefile-pseudo-reg.exp): Add arm pseudo register > tracing test with s5 pseudo register. > diff --git a/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.c b/gdb/testsui= te/gdb.trace/tracefile-pseudo-reg.c > index 3cc3ec0..33761c1 100644 > --- a/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.c > +++ b/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.c > @@ -16,11 +16,15 @@ > along with this program. If not, see .= */ >=20=20 > /* > - * Test program for reading target description from tfile: collects AVX > - * registers on x86_64. > + * Test program for reading target description from tfile: collects pseu= do > + * register on the target. > */ The comment format doesn't comply to GNU coding standard. It should be /* Test program for reading target description from tfile: collects pseudo registers on the target. */ >=20=20 > +#if (defined __x86_64__) > #include > +#elif (defined __arm__) > +#include > +#endif >=20=20 > void > dummy (void) > @@ -35,6 +39,7 @@ end (void) > int > main (void) > { > +#if (defined __x86_64__) > /* Strictly speaking, it should be ymm15 (xmm15 is 128-bit), but gcc o= lder > than 4.9 doesn't recognize "ymm15" as a valid register name. */ > register __v8si a asm("xmm15") =3D { > @@ -48,6 +53,11 @@ main (void) > 0x12340008, > }; > asm volatile ("traceme: call dummy" : : "x" (a)); > +#elif (defined __arm__) > + register uint32_t a asm("s5") =3D 0x3f800000; /* 1. */ > + asm volatile ("traceme: bl dummy" : : "x" (a)); > +#endif > + > end (); > return 0; > } > diff --git a/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.exp b/gdb/tests= uite/gdb.trace/tracefile-pseudo-reg.exp > index 4c52c64..33677a1 100644 > --- a/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.exp > +++ b/gdb/testsuite/gdb.trace/tracefile-pseudo-reg.exp > @@ -12,8 +12,8 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see . >=20=20 > -if { ! [is_amd64_regs_target] } { > - verbose "Skipping tfile AVX test (target is not x86_64)." > +if { ! [is_amd64_regs_target] && ! [istarget "arm*-*-*"] } { > + verbose "Skipping tracefile pseudo register tests, target is not sup= ported." > return > } >=20=20 > @@ -21,8 +21,14 @@ load_lib "trace-support.exp" >=20=20 > standard_testfile >=20=20 > +set add_flags "" > + > +if { [is_amd64_regs_target] } { > + set add_flags "-mavx" > +} > + > if {[prepare_for_testing $testfile.exp $testfile $srcfile \ > - [list debug additional_flags=3D-mavx]]} { > + [list debug additional_flags=3D$add_flags]]} { > return -1 > } >=20=20 > @@ -36,20 +42,31 @@ if ![gdb_target_supports_trace] { > return -1 > } >=20=20 > -gdb_test_multiple "print \$ymm15" "check for AVX support" { > +if { [is_amd64_regs_target] } { > + set reg "\$ymm15" > + set reg_message "check for AVX support" > +} elseif { [istarget "arm*-*-*"] } { > + set reg "\$s5" > + set reg_message "check for register $reg" > +} We can set reg_message out of the condition block, if { [is_amd64_regs_target] } { set reg "\$ymm15" } elseif { [istarget "arm*-*-*"] } { set reg "\$s5" } set reg_message "check for register $reg" --=20 Yao (=E9=BD=90=E5=B0=A7)