From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95833 invoked by alias); 6 Apr 2016 09:05:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95811 invoked by uid 89); 6 Apr 2016 09:04:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:10.98.71.149 X-HELO: mail-pf0-f172.google.com Received: from mail-pf0-f172.google.com (HELO mail-pf0-f172.google.com) (209.85.192.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 06 Apr 2016 09:04:49 +0000 Received: by mail-pf0-f172.google.com with SMTP id c20so29614928pfc.1 for ; Wed, 06 Apr 2016 02:04:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=L5JeSW+gNg+F7Seep7KKMh7qP0w5MTReiIFi5JKNlSI=; b=k7fnyWG8UBDPh1K5POjZmeV8pRJSHhhTlgwLKcLnyAA3Y9oYh9ZU/jGoMKKjGIu7fS C4VQLjJImfI47FdxL6bbaLwlyJVS2/G9UA4UYbdcxkrZGrOWzAjSnIqO0oLoH/+I2jeA dpBKRVK5p0hdJdfoMVeD5b7gjqyCt4ft1HB1e0byDMAzcB9R6ncW25fq7wJk0bWhQ3z/ IE0wdgtJ+TcN0gmax3REyn+mViAw5fbDNynKtT3EQNeDJZ/1S1+gmSdpWXWKbopGTG8k zon1kKGmvo2zkHEx4NOxP1jfvW95B89MKybZbwNZLuRthJRujPgiSdF71/pwDxOVRXGZ NEEw== X-Gm-Message-State: AD7BkJIGX2wqTdeuniJH13hz6a9o/TXzn6wG+PAlwBgfAX10uwXLTLQk3DAydOtVz/2S4Q== X-Received: by 10.98.71.149 with SMTP id p21mr68045844pfi.133.1459933487634; Wed, 06 Apr 2016 02:04:47 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id f12sm3186550pfd.87.2016.04.06.02.04.45 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 06 Apr 2016 02:04:46 -0700 (PDT) From: Yao Qi To: Don Breazeal Cc: , , Subject: Re: [PATCH] Eliminate -var-create error for optzd ptr to struct References: <1459888769-18875-1-git-send-email-donb@codesourcery.com> Date: Wed, 06 Apr 2016 09:05:00 -0000 In-Reply-To: <1459888769-18875-1-git-send-email-donb@codesourcery.com> (Don Breazeal's message of "Tue, 5 Apr 2016 13:39:29 -0700") Message-ID: <86lh4rm7kq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00117.txt.bz2 Don Breazeal writes: >> Please don't. A RETURN_MASK_ALL swallows Ctrl-C/QUIT, and that's almost >> always a bug. The cases you mention translate a QUIT to a python/scheme >> exception, which is not the same as just swallowing the exception. > > Patch below changes that back. Pedro, thanks for clarifying. > No, it doesn't. > @@ -1433,7 +1434,17 @@ value_optimized_out (struct value *value) > /* We can only know if a value is optimized out once we have tried to > fetch it. */ > if (VEC_empty (range_s, value->optimized_out) && value->lazy) > - value_fetch_lazy (value); > + { > + TRY > + { > + value_fetch_lazy (value); > + } > + CATCH (ex, RETURN_MASK_ALL) It should be RETURN_MASK_ERROR. > + { > + /* Fall back to checking value->optimized_out. */ > + } > + END_CATCH > + } Otherwise, patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)