From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ucyMHj79fmqxVCUAWB0awg (envelope-from ) for ; Fri, 14 Aug 2026 07:34:22 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=oZYd07Kv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6BC061E033; Fri, 14 Aug 2026 07:34:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 96C5B1E033 for ; Fri, 14 Aug 2026 07:34:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 155B74BA79AE for ; Fri, 14 Aug 2026 11:34:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 155B74BA79AE Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=oZYd07Kv Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3E5AC4BA7990 for ; Fri, 14 Aug 2026 11:33:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E5AC4BA7990 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E5AC4BA7990 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786707238; cv=none; b=U6bjVlhARNQQ1DXZi9aNWoalBunRyKFhbaGXBL+MM5iQQOL8GnpwNqQpMmwMXtF4ygoS9nNhkbubDdK+YvEbHecI+iwQ11JsUp8apxuApOdYbNECgsH9jvacBQ3Mu23+CQuqwvkFzStCkCJ/ZNfqvnxcPQ+0oZOMSqVrFctZZR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786707238; c=relaxed/simple; bh=62YRgbGAxPnn0NzqqguJldLjhq3BYTiV/mZqK8cZhBQ=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=Bu7dDFiAzLK2gLOXxVUf6TBleOsKYIVitvkTgbhccFFHgZ84PZCHuFk+Q7GGM3NmqD7T3emoHuX0kx81JyxAejWrPL3oXhHVEcr/e/X9juiiAAxeC/Vild5A/nEhOZxMavbxoEehT2PdeLqpcZ/kx3FGUUXolpJntBqCxTgRPVs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=oZYd07Kv DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E5AC4BA7990 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuqAe-0006wV-1G; Fri, 14 Aug 2026 07:33:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=CZjM0TPYe8wFzjEAyMj807e1qFsNHRFcszddKnXJc0g=; b=oZYd07KvPcIW0YKjM0+d +eKWZkx69+Wu+9iZhpXmwNZPfdvSXxOpaDOPaSrdlck0uZxEBrxRsi6VEosSQd5GmZTEcLF/a2qJK Sf/W8pwQ5vsRUFIWWb1Am/a4lAwex0mmV9cCmo7vcF4Ei3mD2wn0ttHm5mFTuQj6M9fsrq7krHBkB bu1dwyShhMOJB3HS7fF9o4kmIFcZt4dX+Wkd9tlD/8PbRCJ40ONm740XB74J5qS4f/X4WXe8/X77v nhMwItvH1zyMQS11f9krBKli4ngUJUiQgOnWyxX7zrWg9fJUtS52Nn9wtiHWWqOhysR8nOQndj9Gg LUHmTTzy4X6YJg==; Date: Fri, 14 Aug 2026 14:33:53 +0300 Message-Id: <86lda97x7i.fsf@gnu.org> From: Eli Zaretskii To: Rainer Orth Cc: gdb-patches@sourceware.org, aburgess@redhat.com In-Reply-To: (message from Rainer Orth on Fri, 14 Aug 2026 11:34:14 +0200) Subject: Re: [PATCH] Fix procfs.c compilation on Solaris References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Rainer Orth > Cc: Andrew Burgess > Date: Fri, 14 Aug 2026 11:34:14 +0200 > > procfs.c doesn't compile on trunk and the gdb-18 branch: > > procfs.c: In function ‘int procfs_notice_thread(procinfo*, procinfo*, void*)’: > procfs.c:2857:33: error: invalid use of non-static member function ‘thread_state thread_info::state() const’ > 2857 | if (thr == NULL || thr->state == THREAD_EXITED) > | ~~~~~~~~~~~^~~~~~~~~~~~~~~~ > > Fixed by calling the member function. > > procfs.c: In function ‘bool find_memory_regions_callback(prmap*, find_memory_region_ftype)’: > procfs.c:3152:15: error: no match for call to ‘(find_memory_region_ftype {aka gdb::function_view}) (CORE_ADDR, std::size_t&, bool, bool, bool, bool, bool)’ > 3152 | return func ((CORE_ADDR) map->pr_vaddr, > | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ > 3153 | map->pr_size, > | ~~~~~~~~~~~~~ > 3154 | (map->pr_mflags & MA_READ) != 0, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 3155 | (map->pr_mflags & MA_WRITE) != 0, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 3156 | (map->pr_mflags & MA_EXEC) != 0, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 3157 | true, /* MODIFIED is unknown, pass it as true. */ > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 3158 | false); > | ~~~~~~ > > Fixed by passing the new HOLE arg. > > procfs.c: In function ‘void info_proc_mappings(procinfo*, int)’: > procfs.c:3257:25: error: too many arguments to function ‘bool iterate_over_mappings(procinfo*, find_memory_region_ftype, bool (*)(prmap*, find_memory_region_ftype))’ > 3257 | iterate_over_mappings (pi, NULL, NULL, info_mappings_callback); > | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixed by removing the unused arg. > > Tested on sparcv9-sun-solaris2.11 and amd64-pc-solaris2.11 with results > similar to the gdb-17 ones. > > Committed to trunk. > > > This patch should also go to the gdb-18 branch: I'm not sure if I should > just commit it or it needs approval. The rule until now was that each bugfix on the release branch needs a Bugzilla report. Thanks.