From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82884 invoked by alias); 15 Sep 2015 13:01:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82872 invoked by uid 89); 15 Sep 2015 13:01:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f172.google.com Received: from mail-wi0-f172.google.com (HELO mail-wi0-f172.google.com) (209.85.212.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Sep 2015 13:01:06 +0000 Received: by wiclk2 with SMTP id lk2so26240809wic.1 for ; Tue, 15 Sep 2015 06:01:03 -0700 (PDT) X-Received: by 10.180.35.163 with SMTP id i3mr7413732wij.55.1442322063012; Tue, 15 Sep 2015 06:01:03 -0700 (PDT) Received: from E107787-LIN ([195.154.84.196]) by smtp.gmail.com with ESMTPSA id lu5sm21039866wjb.9.2015.09.15.06.01.02 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Tue, 15 Sep 2015 06:01:02 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] [GDBserver][AArch64] Add support for fast tracepoints References: <1442230282-20751-1-git-send-email-pierre.langlois@arm.com> <1442230282-20751-5-git-send-email-pierre.langlois@arm.com> Date: Tue, 15 Sep 2015 13:01:00 -0000 In-Reply-To: <1442230282-20751-5-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Mon, 14 Sep 2015 12:31:18 +0100") Message-ID: <86k2rr3khk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00322.txt.bz2 Pierre Langlois writes: > /* List of registers that we are currently using, we can add more here as > + we need to use them. */ > + > +/* General purpose scratch registers (64 bit). */ > +static struct aarch64_register x0 =3D { 0, 1 }; > +static struct aarch64_register x1 =3D { 1, 1 }; > +static struct aarch64_register x2 =3D { 2, 1 }; > +static struct aarch64_register x3 =3D { 3, 1 }; > +static struct aarch64_register x4 =3D { 4, 1 }; > + > +/* General purpose scratch registers (32 bit). */ > +static struct aarch64_register w2 =3D { 2, 0 }; > + > +/* Intra-procedure scratch registers. */ > +static struct aarch64_register ip0 =3D { 16, 1 }; > + > +/* Special purpose registers. */ > +static struct aarch64_register sp =3D { 31, 1 }; > +static struct aarch64_register xzr =3D { 31, 1 }; Add "const"? like "static const struct aarch64_register xzr". I go through it quickly, and it looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)