From: Yao Qi <qiyaoltc@gmail.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org, Yao Qi <yao.qi@arm.com>
Subject: Re: [PATCH v2] gnu_vector.exp: Respect `should_kfail' for PR8549
Date: Wed, 20 Jan 2016 13:49:00 -0000 [thread overview]
Message-ID: <86k2n4s6n6.fsf@gmail.com> (raw)
In-Reply-To: <m337tssc8t.fsf@oc1027705133.ibm.com> (Andreas Arnez's message of "Wed, 20 Jan 2016 12:48:18 +0100")
Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
Hi Andreas,
Patch is OK to me,
> -gdb_test "p res" "\\{4, 2, 7, 6\\}.*" "verify vector return value"
> +set test "verify vector return value"
> +gdb_test_multiple "p res" $test {
> + -re ".*= \\{4, 2, 7, 6\\}\r\n.*$gdb_prompt $" {
> + pass $test
> + }
> + -re ".*= \\{.*\\}\r\n.*$gdb_prompt $" {
> + if { $should_kfail } {
> + # GDB had not actually set the return value, likely due to
> + # PR8549. So accept any return value and emit a KFAIL.
Nit, we need a space between "PR" and "8549".
--
Yao (齐尧)
next prev parent reply other threads:[~2016-01-20 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 11:48 Andreas Arnez
2016-01-20 13:49 ` Yao Qi [this message]
2016-01-20 18:44 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k2n4s6n6.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=yao.qi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox