From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58898 invoked by alias); 25 Jul 2017 15:25:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58784 invoked by uid 89); 25 Jul 2017 15:24:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-it0-f52.google.com Received: from mail-it0-f52.google.com (HELO mail-it0-f52.google.com) (209.85.214.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Jul 2017 15:24:53 +0000 Received: by mail-it0-f52.google.com with SMTP id h199so52814660ith.0 for ; Tue, 25 Jul 2017 08:24:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Q2YMRJfzswtQ3mx9hAvnT1m44BKiyJUGVlkF3k2iIRc=; b=pvC2+zGxe/a6GTZmxBzrIFpL8opoTYKOMcyNeStQxYBl7IjHBbCqvZWZJwNGh8e8vs l5+7XZ8LEID2a9ArBjJTQZH5RR9z2gpPtN+gvQFfdXBPl5CtKIhiFzwBsa1TiE8adGVL 2N9GBCE5ew/1wZrcxgA9FwnWndZ/kgqxF+FWftcQ48/cbbOI7gAY+xjUT+YiRVSZe25q KhVyX53IMHvnusy7Xq6JfUIfHwIXtr9bm0T2cecciHIhCajFgrX5DYmtm2ECV0+pN3FZ IyTjM/PzYLrGjqEM7KBzudpT/V2Q8qFy7AKtAovaZ2KDNvnUS2YVpsSaQUEe8xKwwozs MllA== X-Gm-Message-State: AIVw112XfkIMPwUbqJ7mCM6UJNRthzaGqZepeJj8VVA7WBbnUzmy5gz4 c6zGtK1qLRFuVsZy X-Received: by 10.36.170.69 with SMTP id y5mr10853608iti.143.1500996292159; Tue, 25 Jul 2017 08:24:52 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id n198sm5232679itb.39.2017.07.25.08.24.50 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 25 Jul 2017 08:24:51 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete References: <1500892797-7523-1-git-send-email-simon.marchi@ericsson.com> <1500892797-7523-3-git-send-email-simon.marchi@ericsson.com> <861sp4rg6i.fsf@gmail.com> <872a159d-95a0-f2e1-6100-24d681ff348e@ericsson.com> Date: Tue, 25 Jul 2017 15:25:00 -0000 In-Reply-To: <872a159d-95a0-f2e1-6100-24d681ff348e@ericsson.com> (Simon Marchi's message of "Tue, 25 Jul 2017 12:19:21 +0200") Message-ID: <86k22wpmim.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00367.txt.bz2 Simon Marchi writes: > Oh, thanks for noticing this! I think I've been misguided be the comment= on > linux_fast_tracepoint_collecting that says "true": > > /* Convenience wrapper. Returns true if LWP is presently collecting a > fast tracepoint. */ > > static int > linux_fast_tracepoint_collecting (struct lwp_info *lwp, > struct fast_tpoint_collect_status *status) > > Maybe we should make it return an enum so it's clear, because the functio= n name > really sounds like it would return a bool. > Agreed. The comments to lwp_info.collecting_fast_tracepoint should be updated as well. > > Here's the a fixup to this patch that restores the original code: The patch this fixup is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)