Re: [PATCH] Unbreak DJGPP port of GDB

Eli Zaretskii
2015-05-30T10:11:43Z

> Date: Thu, 28 May 2015 17:41:56 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: gdb-patches@sourceware.org
>
> > From: Yao Qi <qiyaoltc@gmail.com>
> > Cc: gdb-patches@sourceware.org
> > Date: Thu, 28 May 2015 09:46:59 +0100
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > > It turns out the DJGPP (a.k.a. "go32") port of GDB was broken more
> > > than a year ago, by commits 9b40951 and bd265cd. It stayed broken
> > > ever since. Lately, Andris Pavenis bisected the bug and posted the
> > > results here:
> > >
> > > http://www.delorie.com/djgpp/mail-archives/browse.cgi?p=djgpp/2015/05/24/04:17:40
> > >
> > > Looking into those changesets, I've found that the problem was due to
> > > incorrect handling of values returned by functions 'read_child' and
> > > 'write_child', which are part of the DJGPP native debug support.
> >
> > It is broken by my to_xfer_partial patches... sorry about that.
>
> No sweat. I should have been more vigilant in reviewing those patches
> anyway.
>
> > > The patch below fixes that. I will push it in a few days (with an
> > > appropriate ChangeLog entry), if no one objects.
> >
> > The patch looks right to me.
>
> Thanks.

No further comments, so I pushed the changeset, bot to master and to
the 7.9 branch.