From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109174 invoked by alias); 12 Oct 2015 10:35:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109160 invoked by uid 89); 12 Oct 2015 10:35:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f41.google.com Received: from mail-pa0-f41.google.com (HELO mail-pa0-f41.google.com) (209.85.220.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 12 Oct 2015 10:35:02 +0000 Received: by padhy16 with SMTP id hy16so150940093pad.1 for ; Mon, 12 Oct 2015 03:35:00 -0700 (PDT) X-Received: by 10.66.121.110 with SMTP id lj14mr33245018pab.61.1444646100533; Mon, 12 Oct 2015 03:35:00 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id xg2sm17606996pbb.2.2015.10.12.03.34.58 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Mon, 12 Oct 2015 03:35:00 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH c++ 3/5] mep: Add cast for int to enum conversion References: <1444538238-7468-1-git-send-email-simon.marchi@polymtl.ca> <1444538238-7468-3-git-send-email-simon.marchi@polymtl.ca> Date: Mon, 12 Oct 2015 10:35:00 -0000 In-Reply-To: <1444538238-7468-3-git-send-email-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 11 Oct 2015 00:37:16 -0400") Message-ID: <86io6c5q9h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00147.txt.bz2 Simon Marchi writes: Hi Simon, Patch is OK, one nit below, > @@ -2396,7 +2396,10 @@ mep_gdbarch_init (struct gdbarch_info info, struct= gdbarch_list *arches) > /* The way to get the me_module code depends on the object file > format. At the moment, we only know how to handle ELF. */ > if (bfd_get_flavour (info.abfd) =3D=3D bfd_target_elf_flavour) > - me_module =3D elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_= MASK; > + { > + int flag =3D elf_elfheader (info.abfd)->e_flags & EF_MEP_INDEX_MASK; A blank line is needed here. > + me_module =3D (CONFIG_ATTR) flag; > + } > else > me_module =3D CONFIG_NONE; > } --=20 Yao (=E9=BD=90=E5=B0=A7)