From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124504 invoked by alias); 29 Jan 2016 14:08:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124489 invoked by uid 89); 29 Jan 2016 14:08:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pa0-f46.google.com Received: from mail-pa0-f46.google.com (HELO mail-pa0-f46.google.com) (209.85.220.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 29 Jan 2016 14:08:05 +0000 Received: by mail-pa0-f46.google.com with SMTP id uo6so42799593pac.1 for ; Fri, 29 Jan 2016 06:08:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=BYk5FMlWdVHP080axq8F9jpca+QEo2Ys5Zj7eh0qt18=; b=gRFhzznam7r0lqPJDYrE2FFeBqoV3g/Z+VgAlxUTKBr2mK/HmZXy43n5baINtbHH/I HkUFXOnuPFlB3XIGka3mL0KW99TJME9PB8eDX+XgArlsN8edDIL0xVR/IvDB9uUNmSyE OOB455afUpEwp1oAGJO5bAk8m5sJyUiY0to81BsaLaJfwbhEWb2WdzOg0mY0O9NC66f0 OZ5S5kz0xvL/N2DypB42XkPdZFgwuypYE09QnHltrmvBHu69mJWYtvEObaCcFyFUd7zu ri3ZgvN5BIdCeDrmPj8giocBbhpsFnwGZOwYgzxVYdV4bWky94Sxwc3VOxl7zBVKKMuw y+Tw== X-Gm-Message-State: AG10YORqsxLG5mhGW7JNs5UKU/MXstwXBdPFk7M47zNtU4mTOw2uMTTV9MYURIK1s6bEZw== X-Received: by 10.66.185.225 with SMTP id ff1mr13441156pac.97.1454076483815; Fri, 29 Jan 2016 06:08:03 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id l9sm23965579pfb.29.2016.01.29.06.08.01 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 29 Jan 2016 06:08:03 -0800 (PST) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH] Fix two misleading indentation warnings References: <1454006626-10564-1-git-send-email-simon.marchi@ericsson.com> Date: Fri, 29 Jan 2016 14:08:00 -0000 In-Reply-To: <1454006626-10564-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Thu, 28 Jan 2016 13:43:46 -0500") Message-ID: <86io2cpjgh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00721.txt.bz2 Simon Marchi writes: Hi Simon, > diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c > index 533a33a..938261a 100644 > --- a/gdb/xcoffread.c > +++ b/gdb/xcoffread.c > @@ -2381,13 +2381,13 @@ scan_xcoff_symtab (struct objfile *objfile) > if (first_fun_line_offset =3D=3D 0 && symbol.n_numaux > 1) > first_fun_line_offset =3D > main_aux[0].x_sym.x_fcnary.x_fcn.x_lnnoptr; > - { > - record_minimal_symbol > - (namestring, symbol.n_value, > - sclass =3D=3D C_HIDEXT ? mst_file_text : mst_text, > - symbol.n_scnum, objfile); > - misc_func_recorded =3D 1; > - } > + { > + record_minimal_symbol > + (namestring, symbol.n_value, > + sclass =3D=3D C_HIDEXT ? mst_file_text : mst_text, > + symbol.n_scnum, objfile); > + misc_func_recorded =3D 1; > + } > break; This looks an indentation issue. This block was added as a replacement to RECORD_MINIMAL_SYMBOL which was indented correctly. https://sourceware.org/ml/gdb-patches/2012-04/msg00440.html A nit, can we remove the brackets ("{" and "}")? Change to xcoffread.c looks good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)