From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Plumb enum remove_bp_reason all the way to target_remove_breakpoint
Date: Mon, 15 Feb 2016 09:12:00 -0000 [thread overview]
Message-ID: <86io1qe3rd.fsf@gmail.com> (raw)
In-Reply-To: <1455475070-17797-4-git-send-email-palves@redhat.com> (Pedro Alves's message of "Sun, 14 Feb 2016 18:37:49 +0000")
Pedro Alves <palves@redhat.com> writes:
Hi Pedro,
> So the target knows whether we're detaching breakpoints.
> Nothing uses the parameter in this patch yet.
>
> gdb/ChangeLog:
> 2016-02-14 Pedro Alves <palves@redhat.com>
>
> * break-catch-sig.c (signal_catchpoint_remove_location): Adjust
> interface.
> * break-catch-syscall.c (remove_catch_syscall):
> * breakpoint.c (enum remove_bp_reason): Moved to breakpoint.h.
> (remove_breakpoint_1): Pass 'reason' down.
> (remove_catch_fork, remove_catch_vfork, remove_catch_solib)
> (remove_catch_exec, remove_watchpoint, remove_masked_watchpoint)
> (base_breakpoint_remove_location, bkpt_remove_location)
> (bkpt_probe_remove_location, bkpt_probe_remove_location): Adjust
> interface.
> * breakpoint.h (enum remove_bp_reason): Moved here from
> breakpoint.c.
> (struct breakpoint_ops) <remove_location>: Add 'reason' parameter.
> * corelow.c (core_remove_breakpoint): New function.
> (init_core_ops): Install it as to_remove_breakpoint method.
> * exec.c (exec_remove_breakpoint): New function.
> (init_exec_ops): Install it as to_remove_breakpoint method.
> * mem-break.c (memory_remove_breakpoint): Adjust interface.
> * record-btrace.c (record_btrace_remove_breakpoint): Adjust
> interface.
> * record-full.c (record_full_remove_breakpoint)
> (record_full_core_remove_breakpoint): Adjust interface.
> * remote.c (remote_remove_breakpoint): Adjust interface.
> * target-debug.h (target_debug_print_enum_remove_bp_reason): New
> macro.
> * target-delegates.c: Regenerate.
> * target.c (target_remove_breakpoint): Add 'reason' parameter.
> * target.h (struct target_ops) <to_remove_breakpoint>: Add
> 'reason' parameter.
> (target_remove_breakpoint, memory_remove_breakpoint): Add 'reason'
> parameter.
We also need to add 'reason' in m32r_remove_breakpoint,
mips_remove_breakpoint and procfs_remove_breakpoint, otherwise the patch
breaks the all-targets build.
This patch series look good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-02-15 9:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 18:37 [PATCH 0/4] Fix PR gdb/19187 (process record over a fork causes internal error) Pedro Alves
2016-02-14 18:37 ` [PATCH 2/4] Introduce 'enum remove_bp_reason' Pedro Alves
2016-02-14 18:37 ` [PATCH 3/4] Plumb enum remove_bp_reason all the way to target_remove_breakpoint Pedro Alves
2016-02-15 9:12 ` Yao Qi [this message]
2016-02-15 14:41 ` Pedro Alves
2016-02-14 18:37 ` [PATCH 1/4] Simplify remove_breakpoint interface Pedro Alves
2016-02-14 18:44 ` [PATCH 4/4] Fix PR gdb/19187 (process record over a fork causes internal error) Pedro Alves
2016-08-10 22:11 ` [PATCH 0/4] " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86io1qe3rd.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox