From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51983 invoked by alias); 23 Feb 2017 14:58:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51848 invoked by uid 89); 23 Feb 2017 14:58:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 14:58:11 +0000 Received: by mail-wm0-f66.google.com with SMTP id v77so299709wmv.0 for ; Thu, 23 Feb 2017 06:58:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=fW4MsYXgLSq7VprseItfHplGECt/3HYukn33kQNTT38=; b=qCjhFPr2uo4GJg+6lwDh8IaYY6/ld6Q41uMwmNBO+LohxJrw/Tyx5LzvdfIkbTe3yj WavPDX+jmNYyHibmiFQ30Ia7JA3c8Ezu2lcktmM8SYtaB2yltcVZtqS3xIDytaspIwdJ w0xe6Mlmicuof/XfY/Y5cpLHMTB5L6BzZJyfJ3JVof4j/KDeTzxEjpZPdGbsmgYwmhOn G4WJkERrOPvQz79/NbBIxCtfKqzrhBBWKCBRaXVplywu4oZST+BXmGu5AR/F+8jvqblX sKo0ytU3rkydH6L/qnC8SQF56P/jXQAe5HImkxF9Dq9Z/P+AobbL9mcRC0nh8qi4NC+b 7+ZA== X-Gm-Message-State: AMke39kzg/eY7DUzWtaJmvSB0UceSasYVEVQ+ja8PpDenUmQ2VEkl60W+E2K1B9ELNGbbw== X-Received: by 10.28.113.9 with SMTP id m9mr5205791wmc.60.1487861889585; Thu, 23 Feb 2017 06:58:09 -0800 (PST) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id 96sm6357127wrb.14.2017.02.23.06.58.08 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 23 Feb 2017 06:58:09 -0800 (PST) From: Yao Qi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v1.2 1/3] Introduce gdb::function_view References: <1487775033-32699-1-git-send-email-palves@redhat.com> <1487775033-32699-2-git-send-email-palves@redhat.com> <8636f39b5e1e2cbdeabbf8dfd999e709@polymtl.ca> <4c8528d8-0115-3bf3-0a16-42f44be580a9@redhat.com> <20baebcd-0f6a-89ca-ef34-503795171d43@redhat.com> <20170222222316.xaeqa67lmil52c7j@localhost> Date: Thu, 23 Feb 2017 14:58:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 23 Feb 2017 14:50:11 +0000") Message-ID: <86ino1ar9e.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00625.txt.bz2 Pedro Alves writes: > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS): New. > (SFILES): Add $(SUBDIR_UNITTEST_SRCS). > (COMMON_OBS): Add $(SUBDIR_UNITTEST_OBS). > (%.o) : New pattern. > (INIT_FILES): Add $(SUBDIR_UNITTESTS_SRCS). > * common/function-view.h: New file. > * unittests/function-view-selftests.c: New file. Patch is good to me. Nit, CL entry on configure.ac is missing. --=20 Yao (=E9=BD=90=E5=B0=A7)