From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44187 invoked by alias); 13 Apr 2017 09:10:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44166 invoked by uid 89); 13 Apr 2017 09:10:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wr0-f174.google.com Received: from mail-wr0-f174.google.com (HELO mail-wr0-f174.google.com) (209.85.128.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 09:10:04 +0000 Received: by mail-wr0-f174.google.com with SMTP id l28so31680423wre.0 for ; Thu, 13 Apr 2017 02:10:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=poPKu3u72uq4n2C6ENXGmq5GNTDkDZc64XlcKsxZsII=; b=RcTYKfNHg5W2jylLfvek2VU69prlTPGnavnSv4bwrPA/6BQ2TaDKNceFjg0cqN2gHX yAYAQBp80MhFPCcDOfuqQjhv/TKX7eEIrAMvu/B2WrMzTleG+iEQiR6GfNPTwA/Thej0 UPK5lu4JPENpJzxX/wXhDuRKpsQ4U0PXldx2NUmJSzk/a2rOlgjFdM7ZVjXIFoSb46/A RtHTMF/SqugIsZzgISpHfgg/KnsT6T33HyEVkdOj3kty++jXvclAx9DVDvcpnC9zrnyL uMvvn6WNVihrM02V9HrXSC5WLFExX6sS/5Mxs/oyxmOvzSD1Cwy98uxQgGGyADSDPcmI 4/wg== X-Gm-Message-State: AN3rC/7VbAH9eol5EuBj7yZwtq4zGri2WVuZGIFAw1uarxRgF0i5btLe J/6KkJk5jFweow== X-Received: by 10.223.145.227 with SMTP id 90mr1918271wri.170.1492074603845; Thu, 13 Apr 2017 02:10:03 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id i144sm9732573wmf.13.2017.04.13.02.10.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 13 Apr 2017 02:10:03 -0700 (PDT) From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/9] Remove addr_size field from struct piece_closure References: <1491586736-21296-1-git-send-email-arnez@linux.vnet.ibm.com> <1491586736-21296-5-git-send-email-arnez@linux.vnet.ibm.com> Date: Thu, 13 Apr 2017 09:10:00 -0000 In-Reply-To: <1491586736-21296-5-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Fri, 7 Apr 2017 19:38:11 +0200") Message-ID: <86inm8ad1y.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00407.txt.bz2 Andreas Arnez writes: > The addr_size field in the piece_closure data structure is a relic from > before introducing the typed DWARF stack. It is obsolete now. This patch > removes it. > > gdb/ChangeLog: > > * dwarf2loc.c (struct piece_closure) : Remove field. > (allocate_piece_closure): Drop addr_size parameter. > (dwarf2_evaluate_loc_desc_full): Adjust call to > allocate_piece_closure. LGTM. --=20 Yao (=E9=BD=90=E5=B0=A7)