From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20053 invoked by alias); 22 Jun 2017 15:58:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19093 invoked by uid 89); 22 Jun 2017 15:58:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:841, H*r:sk:static. X-HELO: mail-it0-f44.google.com Received: from mail-it0-f44.google.com (HELO mail-it0-f44.google.com) (209.85.214.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 15:58:49 +0000 Received: by mail-it0-f44.google.com with SMTP id m62so52936112itc.0 for ; Thu, 22 Jun 2017 08:58:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=OD9rPuvvldG1iPTSrhBvpZWRmE+pS5a++cgbpUPmtaY=; b=RMf8QptZPWDN/dyeyqXmOdzn1eUBAb+Y1qzkA1NtJRO9+IgiRusLmuCA/dDnqnv9UF r1qG++IipjUwZh9Jbxtg/6ifffAYSRK8u0qQLe0eG3ByuJJNMau+AQE7i2687QaYdZ7B vCKNqKK7boag5Culm5QLuePwr32zSVtTtJzcmiFuIy4gr+SAt0Yj3XIO/F8xCTEG+sQZ qVW13wMeJesqhsB6FYmkmRMSDODDLFW4bSMqZzr0E2IdZSCRzEwo3M2SKHKDusXzwDm8 yI1Op6ymNxL5KBLe0SJZA9vhby6dQ2+R7sriIiyw6otBAXRzWe6zGHbwp1n0zxll7AR/ xVvg== X-Gm-Message-State: AKS2vOyUz+MUY5TXVUyAbH/WL0zOnrP/YvLPO+CG10ds18eR4c8UAgre BW2mr4de63CKZ/OL X-Received: by 10.36.154.7 with SMTP id l7mr2709758ite.108.1498147128045; Thu, 22 Jun 2017 08:58:48 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id h76sm1152013ith.24.2017.06.22.08.58.46 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 22 Jun 2017 08:58:47 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/25] Generate c for feature instead of tdesc References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-7-git-send-email-yao.qi@linaro.org> <86mv90hyci.fsf@gmail.com> <81c7a0ce-71a9-f9dc-e5e3-47f8d162d20d@redhat.com> Date: Thu, 22 Jun 2017 15:58:00 -0000 In-Reply-To: <81c7a0ce-71a9-f9dc-e5e3-47f8d162d20d@redhat.com> (Pedro Alves's message of "Thu, 22 Jun 2017 16:36:34 +0100") Message-ID: <86injohv4a.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00655.txt.bz2 Pedro Alves writes: > "*.xml.tmp.tmp" to "*.xml.tmp". I.e., from $@.tmp to $@, just > like the rule further above. > Oh, I know what you mean. > I may be missing something, but AFAICS, the "%.xml.tmp: %.xml" > rule is writing to the target directly. If the build > is interrupted in the middle of that rule, we end up with an > incomplete "%.xml.tmp" file left over in the file system. > Then the next time you invoke make, make will think that > the "%.xml.tmp" file is already up to date and won't rebuild it. > As a result, you'll pass a broken xml.tmp file to > "maint print c-tdesc". > > Avoiding these issues is the whole point of move-if-change, > by atomically creating the target file. move-if-change is needed here. Let me add it. --=20 Yao (=E9=BD=90=E5=B0=A7)