From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qXraBAzDhmZCXBsAWB0awg (envelope-from ) for ; Thu, 04 Jul 2024 11:43:08 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=Itx+gMys; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 022F01E0C3; Thu, 4 Jul 2024 11:43:08 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E6DE21E030 for ; Thu, 4 Jul 2024 11:43:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 718E4384A45A for ; Thu, 4 Jul 2024 15:43:05 +0000 (GMT) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3A13B3858C41 for ; Thu, 4 Jul 2024 15:42:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A13B3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A13B3858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720107767; cv=none; b=e+c83nN8fLv8vY1NzJJpDbellYnsiYzcYponsrV5aPBSRVLxzEtAwPG0FoUTV0O81QYFArHhg52Hh7Ee0NBv2eeRbDe7pe+/qsSMc3hkArRPjVu0tz+Ij+RsS3NcfguRtkTuzRSLtbcre3G5J5k7kZdQU1muvObsYGir4NI1pys= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720107767; c=relaxed/simple; bh=Kk3F1yhlTD7KARLSb7xwFSiHgLalMybY88xKeL5YPmw=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=FbygRqHxUpQi/4YR9uE+KWXgwU/Wdo5D2b+XzuxfT0t7rzQcDjFmPJnpPnrhu4utU97472MlRutEK9r+iRLJjmIYoOC8vRgv0skAScapLvKkoiU1dKi0dwJ/zI+fqTcNVN+6NWWa+O/15q/otvOnbQ6fibEdvN9m/Zpg6B8cUls= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPObd-0004Nk-Qn; Thu, 04 Jul 2024 11:42:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0BKOleNWzJ4aABZTYs6KaRgfZHl/4C7QZbX/gxHM6DE=; b=Itx+gMyskvz0 D92XPC53atNUqox6WpSCjTZufvTxP/Weun9vUO6CrIzGx7r7VlSoIegOUuFGdJjkXAcu645lOWcxZ 4muB+hMMovwGuPe6xvlJ6R6d9NiPOwp515cY81Ke3dSwGSe8ehvUwnPyTkCbhKMMEuRMgfGX2hEnE csW6p5QuPBv0GPLBm0AhQ9uQmzBWC4Gh0Yjum4JNRskjmr5mGFV/Bp1q5Dxc5UXgVRplDEO9zuO2L gN5S8XBY9HtZvS5CpFYw3ILTgqxMsAI8NDnrGnWCV7JX0oBC6wNKX6rqocn0fqkG/uFwNAL8t7dgN cWPLOnk5Mg0wOqkfkfWFtg==; Date: Thu, 04 Jul 2024 18:42:42 +0300 Message-Id: <86ikxl88p9.fsf@gnu.org> From: Eli Zaretskii To: Andrew Burgess Cc: gdb-patches@sourceware.org In-Reply-To: <351179c8d62d8dbd971679c1322757eb35ff4713.1720101827.git.aburgess@redhat.com> (message from Andrew Burgess on Thu, 4 Jul 2024 15:21:08 +0100) Subject: Re: [PATCHv4 13/14] gdb: allow quoted filenames for commands that have custom completion References: <351179c8d62d8dbd971679c1322757eb35ff4713.1720101827.git.aburgess@redhat.com> X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Andrew Burgess > Cc: Andrew Burgess > Date: Thu, 4 Jul 2024 15:21:08 +0100 > > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -23,6 +23,13 @@ remove-symbol-file -a ADDRESS > multiple terms, e.g. 'function + 0x1000' (without quotes), > previously only a single term could be given. > > +compile file > +maint print c-tdesc > +save gdb-index > + These commands now require their filename argument to be quoted if > + it contains with white space or quote characters. If the argument ^^^^ The "with" part should be removed. Also, are white space and quotes the only special characters for these commands? > + contains no special characters then quoting is not required. ^^^^^^^^^^^^^^^^^^^^^ I suggest to say here "no such special characters", to make absolutely clear that you are talking about white space and quotes mentioned earlier by their names. Thanks. Reviewed-By: Eli Zaretskii