From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pu//BFtlJ2h/iyUAWB0awg (envelope-from ) for ; Fri, 16 May 2025 12:18:35 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=WQxdPXvI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 04DF91E10E; Fri, 16 May 2025 12:18:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 821541E092 for ; Fri, 16 May 2025 12:18:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A1ED385F029 for ; Fri, 16 May 2025 16:18:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A1ED385F029 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=WQxdPXvI Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 87F24385ED69 for ; Fri, 16 May 2025 16:17:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87F24385ED69 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87F24385ED69 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747412221; cv=none; b=gnREnqjK6npmDxzVsEmwtkkK5ENFmy+4O+vwKAzKoOd7xtzbGS4QSV43UuDMbaQchhhwrpKsLDfFm0UtbIJYDVQH+2rXRFAtuK6rM7mvg4/1pHwe4RK1X2eBG0BkFTIq+SRNHUycLxG8G23ngWbNKxYfnrPej++bNtUPVBZcGYo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747412221; c=relaxed/simple; bh=2BZLmT4h2N9uYfrV8Xl3YgnR9/gNTawtFr6sMBmCtV0=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=EmMCwqCCAxenP2K/0JU3mBZnMZ7C65B14ArB+mo1OR462m1N2o2Nn89hYOSGnGK5bmFLFZ4ggupvaTT4LxdJZgQBsRBM4V4BPWCAy/x9un3MCyHHdN0IAqQRlk6pQteY7WCTqYYGlORPZBKFRTLmaJDxy/fg5Vr8gZq1vQMUS9A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87F24385ED69 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFxk3-0005Jg-M5; Fri, 16 May 2025 12:17:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LzFsNy4qd/An44Oy7Q9qbUlyrKD4UdFikHW12vzKAKY=; b=WQxdPXvIAcOx WjAkMfwb5deUqh6ThgMADPb3NZZq/eaopYXceOFlILOSN2ITRTsDBjWxqCWWjUv2phn+E0MHON6+p INaBeHrn58O/krVL0NTKe7w7/JCLfthBGET31jLeCxEup+vPlpWShoOk7Lv+SX9v3Z7xbA8W7j7Kw kbWd0dLfsEPdwwsm7/a3dYFxe/JlHZVXvVDiw/ry83Or3rULVGzIr/iUHMQ0WxnFpw8zF4BWzcR+s qrg3TtIHivpKrL2CgOEnoEuksFTHq8N5aK99JOATlbrg44C1esvar18OWGXNlnXuTH6NY53VXNpKY pDBK3aQTVcmk060br8JXxQ==; Date: Fri, 16 May 2025 19:16:57 +0300 Message-Id: <86ikm0y1hi.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: aburgess@redhat.com, gdb-patches@sourceware.org In-Reply-To: <87wmag63jg.fsf@tromey.com> (message from Tom Tromey on Fri, 16 May 2025 08:20:03 -0600) Subject: Re: [PATCH 2/2] Allow check-mark to be changed for CLI References: <20250509-emoji-check-mark-v1-0-63b6c52411f3@adacore.com> <20250509-emoji-check-mark-v1-2-63b6c52411f3@adacore.com> <87zfffnqrj.fsf@redhat.com> <87wmag63jg.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Tom Tromey > Cc: Tom Tromey , gdb-patches@sourceware.org > Date: Fri, 16 May 2025 08:20:03 -0600 > > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Tom Tromey writes: > >> In keeping with the emojification of gdb, this patch changes the > >> default "current" marker to be a check-mark. It adds a knob to allow > >> the character to be changed, and, as always, reverts to the old output > >> when emojis are disabled. > > Andrew> I haven't tested this patch just yet (short of time), but I wonder if I > Andrew> set the check-mark character to a multi-character string, does that > Andrew> corrupt the output? I'm guessing so as I don't think table columns > Andrew> auto-adjust. > > Andrew> So my real question: at a minimum, should the docs mention that the > Andrew> STRING should only be a single character. And better yet, can we check > Andrew> that the string is only a single character in width somewhere? > > Yeah, I will update the docs in v2. > > I don't think there's any way to figure out what the display width of a > string might be. At least, not unless gdb adds a dependency on > something like libicu. I don't think even libicu will be enough, because the terminal emulators vary in this respect. There's some recent protocol to help with this, but I don't think it's supported widely enough for GDB to rely on it.