Re: [PATCH v6] Enable tracing of pseudo-registers on ARM

Antoine Tremblay
2016-02-25T18:19:25Z

Pedro Alves writes:

> On 02/25/2016 03:32 PM, Antoine Tremblay wrote:
>> In this v6:
>> * use https://sourceware.org/ml/gdb-patches/2016-02/msg00786.html to map
>> registers to remote registers. (This is already in master)
>> * Fix test changelog
>> * Test is already renamed, update patch.
>> -
>> This patch implements the ax_pseudo_register_push_stack and
>> ax_pseudo_register_collect gdbarch functions so that a pseudo-register can
>> be traced.
>>
>
> FAOD, I'm happy with this version, if Yao is happy.
>
OK. I'll wait for Yao's review.

>> dummy (void)
>> @@ -37,6 +41,7 @@ main (void)
>> {
>> /* Strictly speaking, it should be ymm15 (xmm15 is 128-bit), but gcc older
>> than 4.9 doesn't recognize "ymm15" as a valid register name. */
>> +#if (defined __x86_64__)
>
> The comment should be within the #if.
>
Fixed, thanks.

Antoine