From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9576 invoked by alias); 29 Jun 2017 08:29:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8158 invoked by uid 89); 29 Jun 2017 08:29:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-io0-f195.google.com Received: from mail-io0-f195.google.com (HELO mail-io0-f195.google.com) (209.85.223.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Jun 2017 08:29:49 +0000 Received: by mail-io0-f195.google.com with SMTP id 84so435730iop.2 for ; Thu, 29 Jun 2017 01:29:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=to+DiKdSVwSKVgqau74yThnGEKvm/Hnle3SFQxbiRHU=; b=QW7FUFDc24M2avfQawzKYFx09O0m4Fa95YIBuUY1XxVikMODUgAd2pRhQvqV+6JZtj nYCngmIDeMH6EFS7oYPo6YgXDvEhrAQnP4Y2of9tCDLCqU2x0wCLcI2oAaflOpasY7Vl RbzgTrbchITfgTX28SMGaHtYKSuL+wlmqdxsmg5PTdVe1Aq+D5ieD0+LJ9B9WVrWmGfs BTseLhydsT9kk21QaVLRpbPWtrgNxW/NYGSpfFpFuun3KdzISBLq7381xY5QGY+EeeT8 wNS6/2Iw4Ul910RLiNa67k4dkpn6K9YuWXaGJlNnvXGgZqo5LE7J2yjFsL8oqc6mP2mN PIXA== X-Gm-Message-State: AKS2vOwhmuZQADPtuGGRYr2g0YmkhzeNKKUVWYhax2GHR9DNrU/4fIzD v6dbVMusm6DPC2kB X-Received: by 10.107.141.214 with SMTP id p205mr15559055iod.43.1498724987396; Thu, 29 Jun 2017 01:29:47 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id m136sm280092itb.7.2017.06.29.01.29.46 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 29 Jun 2017 01:29:46 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/40] Expression completer should not match explicit location options References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-7-git-send-email-palves@redhat.com> Date: Thu, 29 Jun 2017 08:29:00 -0000 In-Reply-To: <1496406158-12663-7-git-send-email-palves@redhat.com> (Pedro Alves's message of "Fri, 2 Jun 2017 13:22:04 +0100") Message-ID: <86h8yzdwng.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00779.txt.bz2 Pedro Alves writes: > Currently, the expression completer matches explicit location options, > which would only make sense for commands that work with linespecs, not > expressions. > > I.e., currently, this: > "p -functi" > > Completes to: > "p -function " I don't know much about completer, expression and explicit location, so I don't know what do you fix here, anything wrong in the completion? > > This patch fixes that, and adds regression tests. --=20 Yao (=E9=BD=90=E5=B0=A7)