Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [AArch64 Linux] Get rid of top byte from tagged address
Date: Thu, 19 Oct 2017 13:17:00 -0000	[thread overview]
Message-ID: <86h8uvuvj8.fsf@gmail.com> (raw)
In-Reply-To: <98b855a4-77df-1bd6-d20d-5b2611cc8f83@redhat.com> (Pedro Alves's	message of "Thu, 19 Oct 2017 12:08:59 +0100")

Pedro Alves <palves@redhat.com> writes:

> This means with something like:
>
> #define tagptr(PTR) \
>  ((typeof (PTR)) ((uintptr_t) (PTR) | 0xf000000000000000ULL))
>
>   strcat (buf, "hello\n");
>
>   char *ptr = tagptr(buf);  // assume this is hidden from view.
>
>   write (1, ptr, 6);  // kernel rejects this.
>

Right, it returns -1, and errno is EFAULT.

> and then the user might be puzzled because stepping through
> that code:
>
>   (gdb) print ptr
>   (gdb) print ptr[0]
>
> etc. works without error.

That is right/expected to me, because in the c code, we can still access
ptr[0] without any error, like "char c = ptr[0]", so it is reasonable
that we can access them in GDB.  Kernel rejects that address, doesn't
mean we can't access that address.

>
> Same with iovec/readv, ioctl, etc., any system call that takes
> a pointer argument.

-- 
Yao (齐尧)


  reply	other threads:[~2017-10-19 13:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  8:08 Yao Qi
2017-10-19  9:51 ` Ramana Radhakrishnan
2017-10-19 10:53   ` Yao Qi
2017-10-19  9:52 ` Pedro Alves
2017-10-19  9:55   ` Ramana Radhakrishnan
2017-10-19 10:51   ` Yao Qi
2017-10-19 11:09     ` Pedro Alves
2017-10-19 13:17       ` Yao Qi [this message]
2017-10-19 13:22         ` Pedro Alves
2017-10-19 11:21 ` Pedro Alves
2017-10-19 13:25   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86h8uvuvj8.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox