From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47542 invoked by alias); 22 Jan 2018 15:47:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47405 invoked by uid 89); 22 Jan 2018 15:47:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static., presentation X-HELO: mail-wr0-f178.google.com Received: from mail-wr0-f178.google.com (HELO mail-wr0-f178.google.com) (209.85.128.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jan 2018 15:47:06 +0000 Received: by mail-wr0-f178.google.com with SMTP id g38so9165810wrd.2 for ; Mon, 22 Jan 2018 07:47:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=88zeIwOwZFmy6h95QZk2xJzt5ZKUy5edv/5xKFHyQ/w=; b=azPduB1i2kCBIQcuRUGc0UUpat2TyznKTJk/OHMt6TwgWFK7GhuTrgI2XikTi6iPfT n/eybEns1MmaHs6M6yVciLffHLcVjAsbm1Tl7LjHqdBng/FpPD46ZNzdut86f9mXR8DF QAsI8Tu9afHfQj9HtqqtwbGy3ZO66x0Vdl3MSdsLS3LIfHeEgw82QVrjl1kWsRxXrX3V BXCEGPvNoqXfBc1jcTgIrPHzQcbmr83MAhAgfXP/O2nNiBdzHzzJc5Tq4mZkykaf4Ya+ NCCiGEJ6I4/cHIOR37SJdaiWs5yoX8hjsIetkhe+PHLk7OPCyVZtot38PMoLH9h0Qt9o ueTQ== X-Gm-Message-State: AKwxyte61KB1dqYJZI9saBzI6pyItDxu7/kYH0/M1P5/pjBOr6V6GOxx aR/YqAfwp5b+wumiz/EpFBArXQ== X-Google-Smtp-Source: AH8x227wihSFd+0GYOuQ5Ufyj8krpZUYIpONja2J5epncNCmgTsBVnMklZDFqiB47qz8u6K7bgGwdQ== X-Received: by 10.223.192.139 with SMTP id d11mr6255891wrf.260.1516636024645; Mon, 22 Jan 2018 07:47:04 -0800 (PST) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id z74sm2622153wmz.21.2018.01.22.07.47.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 22 Jan 2018 07:47:02 -0800 (PST) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 1/6] : Commonise various target-descriptions.c functions References: <74709F15-AABE-4539-867F-4DBD8835D6CC@arm.com> Date: Mon, 22 Jan 2018 15:47:00 -0000 In-Reply-To: <74709F15-AABE-4539-867F-4DBD8835D6CC@arm.com> (Alan Hayward's message of "Mon, 22 Jan 2018 14:06:10 +0000") Message-ID: <86h8rdew0d.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00446.txt.bz2 Alan Hayward writes: > Did you want me to change the ordering of the patches in the series or di= d you > want me to reduce the amount of code that gets moved into arch/ ? > Both. > When I wrote the whole patch series, I only moved across the functions I = needed > from gdb to arch/. It turns out that I needed to move a lot of > functions. Without > complicating the code, I think I need everything I moved into arch/ > > After I had finished writing my code, I looked at the ways of > splitting it up into a > series. The simplest method was to put all the moving of functions > into the first > patch. I agree that this makes the first patch a little odd to > review. My reasoning > was to keep changes to the moved code separate from the moving. > For some big patch series, the patches (order and contents) I posted for review are different from the patches I wrote to get things done. After I get my branch working, I'll restart a new branch, to rewrite them in a way which is more friendly for review/upstreaming, because you've never know what changes are needed until you finish the work. It happens to me that I realize that I need to refactor some part after I committed ten patches in my branch, so I have to stop, rebase my patches, to put refactor patches first. > I can look at making a new version of 2/6 the first patch, and then follo= w with > smaller versions of this patch? The final change across the whole series = would > be the same.=20 That will be very helpful. Steps matter, take a look at page 6 of my presentation, https://gcc.gnu.org/wiki/cauldron2013?action=3DAttachFile&do=3Dget&target= =3Dport-gdb-tic6x-qi.pdf --=20 Yao (=E9=BD=90=E5=B0=A7)