From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6glvLZlwlWpTUhcAWB0awg (envelope-from ) for ; Mon, 31 Aug 2026 08:16:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=WSzSjdYS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9D7DA1E033; Mon, 31 Aug 2026 08:16:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C58B81E033 for ; Mon, 31 Aug 2026 08:16:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25B764BA23C4 for ; Mon, 31 Aug 2026 12:16:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25B764BA23C4 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=WSzSjdYS Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3438D4BA2E2F for ; Mon, 31 Aug 2026 12:16:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3438D4BA2E2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3438D4BA2E2F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788178560; cv=none; b=V6rNKCdjXhmX8N+0wMklAWGtxCuiMFqvsZRtfE4GCvLA1VtbMfDcA5tvXP29NiQO5BcxU3W4yE2DswzdryqL6hKmRf7RlwijxACZKRCUmNHmEeyoR2PletzViEhIPKMaTcMQtKbTCfXxL9qhrtZlA5rVCZ1L94BzML64BM0Hd8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788178560; c=relaxed/simple; bh=00zZ3DFwmbrHHxia6utjGeVLV2H+R/nXR8wGrgFwDJk=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=j6APNCD7OYwQhFoj1yTzH9wSbxh6BSYy5wlMWgpnZsHjFrD5aFevYYZE0z/HRTfw1iZ4yx5srcVPWJrlshBVORgKc5P3O9q6xXnnXqRrCqhyA6UUTwZZIT402hV3COpF6cUEj30MIoofI5CYyv3PNy9huE4ctGGID+qTLEBqOp0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=WSzSjdYS DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3438D4BA2E2F Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x10ve-0003bT-4h; Mon, 31 Aug 2026 08:15:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AyHAtuVnHRRWZb+H3bjvj/Zw9Wj8vXuVRF38vV6ZlyY=; b=WSzSjdYSMwPR 9gur2eyt73W4g73T6tiEo3Fqt8eduNU+4pVwieXD5NFe1G0MSG7h8OBzjLwjLF2LjBEDxpdvtXbOB QeUB62+QpWXw413ghFt37PEyb6d8XWrUA5T7SSsV4wKECctB2UsXK9bWt5oa3muXtrSLfRggM95gA bseJDj82mvBnm5Ctmy05GmqoEP4Xd6MPbhzs3WD8xFWFMCM5j3w9RXJIzbFGNr1mgTsV++/hh1WeW 212btkfP5aq1YNxGPu6BMRN5hrl7oMCieyx7JevrQN/1+Ei/QQvTACS8N7wCwbWzezG65aAHEvi1E T3yX/6Pjo9zAD4MjKQ1o5w==; Date: Mon, 31 Aug 2026 15:15:54 +0300 Message-Id: <86h5ka8ozp.fsf@gnu.org> From: Eli Zaretskii To: Tom de Vries Cc: gdb-patches@sourceware.org, dj@delorie.com In-Reply-To: <6a252b3f-d0c3-4744-97ea-af18822674b1@suse.de> (message from Tom de Vries on Mon, 31 Aug 2026 13:54:56 +0200) Subject: Re: [PATCH] [gdb/config/djgpp] Make djcheck.sh and djconfig.sh shellcheck-clean References: <20260831100826.3521717-1-tdevries@suse.de> <86pkyy8qbn.fsf@gnu.org> <6a252b3f-d0c3-4744-97ea-af18822674b1@suse.de> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > Date: Mon, 31 Aug 2026 13:54:56 +0200 > Cc: gdb-patches@sourceware.org, DJ Delorie > From: Tom de Vries > > On 8/31/26 1:47 PM, Eli Zaretskii wrote: > >> From: Tom de Vries > >> Date: Mon, 31 Aug 2026 12:08:26 +0200 > >> > >> Make gdb/config/djgpp/{djcheck.sh,djconfig.sh} shellcheck-clean: > >> - add missing quotes > >> - add "|| exit 1" after cd > >> - use printf instead of echo -n > >> - use $() > >> - disable SC2016 for "configure --prefix='${DJDIR}' assuming ${DJDIR} is > >> indeed not meant to be expanded > > > > What's the problem with `foo` that you replace it with $() everywhere? > > > > Here ( https://www.shellcheck.net/wiki/SC2006 ) it's mentioned: > ... > Rationale > > Backtick command substitution `...` is legacy syntax with several issues. > > It has a series of undefined behaviors related to quoting in POSIX. > It imposes a custom escaping mode with surprising results. > It's exceptionally hard to nest. > > $(...) command substitution has none of these problems, and is therefore > strongly encouraged. > ... > > > I don't remember, but there's a risk that DJGPP ports of Bash might > > not support the latter. > > I suppose I can suppress this rule in the entire directory using a > .shellcheckrc entry. Thanks, maybe DJ will have an opinion or suggestions.