From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19407 invoked by alias); 26 Jun 2003 15:09:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19392 invoked from network); 26 Jun 2003 15:09:32 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 26 Jun 2003 15:09:32 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h5QF9VuJ000890; Thu, 26 Jun 2003 17:09:31 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h5QF9VEx001052; Thu, 26 Jun 2003 17:09:31 +0200 (CEST) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h5QF9VGH001049; Thu, 26 Jun 2003 17:09:31 +0200 (CEST) To: Andreas Jaeger Cc: gdb-patches@sources.redhat.com Subject: Re: Fix push_arguments on x86-64 References: From: Mark Kettenis Date: Thu, 26 Jun 2003 15:09:00 -0000 In-Reply-To: Andreas Jaeger's message of "Thu, 26 Jun 2003 08:38:53 +0200" Message-ID: <86fzlwq3is.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2003-06/txt/msg00791.txt.bz2 Andreas Jaeger writes: > Ok to commit to both mainline and 6.0 branch? > > 2003-06-26 Andreas Jaeger > > * x86-64-tdep.c (x86_64_push_arguments): Always set %rax to number > of SSE registers so that varargs functions work. > Rework handling of passing arguments on the stack. I believe that the whole argument classification functionality is more complex than it needs to be based on reading the ABI, but it seems to be an improvement and I trust you know what you're doing, so yes, this is approved. Mark