Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] perf testsuite: python 3 fixes
Date: Fri, 08 Jan 2016 11:29:00 -0000	[thread overview]
Message-ID: <86fuy8wbr5.fsf@gmail.com> (raw)
In-Reply-To: <1452203012-19728-1-git-send-email-simon.marchi@ericsson.com>	(Simon Marchi's message of "Thu, 7 Jan 2016 16:43:32 -0500")

Simon Marchi <simon.marchi@ericsson.com> writes:

> There are a few errors when trying to run the performance testsuite with
> Python 3.  This commit fixes them.
>
> In Python 2, it was possible to use relative imports (importing a module
> relative to the current one).  In Python 3 it isn't.  So I use
> absolute_import from the __future__ module, which allows Python 2 to
> behave like Python 3, and use the Python 3 syntax.
>
> In Python 3, dict.iterkeys doesn't exist anymore.  Using dict.keys is a
> good compromise in this case.
>
> gdb/testsuite/ChangeLog:
>
> 	* gdb.perf/lib/perftest/perftest.py: Change relative imports to
> 	absolute.
> 	(SingleStatisticTestResult.report): Use dict.keys instead of
> 	dict.iterkeys.

Patch is fine with me.

-- 
Yao (齐尧)


  reply	other threads:[~2016-01-08 11:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 21:43 Simon Marchi
2016-01-08 11:29 ` Yao Qi [this message]
2016-01-08 15:23   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86fuy8wbr5.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox