From: Yao Qi <qiyaoltc@gmail.com>
To: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: gdb-patches@sourceware.org,
Francois Bedard <Francois.Bedard@synopsys.com>
Subject: Re: [PATCH 3/3] arc: Add support for Newlib
Date: Tue, 11 Oct 2016 14:14:00 -0000 [thread overview]
Message-ID: <86fuo39dn5.fsf@gmail.com> (raw)
In-Reply-To: <1475843870-11449-3-git-send-email-Anton.Kolesov@synopsys.com> (Anton Kolesov's message of "Fri, 7 Oct 2016 15:37:50 +0300")
Anton Kolesov <Anton.Kolesov@synopsys.com> writes:
Hi Anton,
> +/* Implement the 'init_osabi' method of struct gdb_osabi_handler. */
> +
> +static void
> +arc_newlib_init_osabi (struct gdbarch_info info, struct gdbarch *gdbarch)
> +{
> + if (arc_debug)
> + debug_printf ("arc-newlib: Initialization.\n");
> +
> + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
> +
> + /* Offset of original PC in longjmp jump buffer (in registers). Value of PC
> + offset can be found in newlib/libc/machine/arc/setjmp.S. */
> + tdep->jb_pc = 18;
What is jb_pc on arc-linux? Is it 18 or a different one? If it is 18
too, we can use arc_get_longjmp_target for both newlib and linux. Patch
#1 is not needed.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-10-11 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 12:38 [PATCH 1/3] arc: Add a gdbarch_tdep structure Anton Kolesov
2016-10-07 12:38 ` [PATCH 2/3] arc: Add evaluation of long jump targets Anton Kolesov
2016-10-11 16:22 ` Yao Qi
2016-10-07 12:38 ` [PATCH 3/3] arc: Add support for Newlib Anton Kolesov
2016-10-11 14:14 ` Yao Qi [this message]
2016-10-11 15:36 ` Anton Kolesov
2016-10-11 16:25 ` Yao Qi
2016-10-12 11:57 ` Anton Kolesov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fuo39dn5.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=Anton.Kolesov@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox