From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40839 invoked by alias); 27 Jun 2017 10:57:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40820 invoked by uid 89); 27 Jun 2017 10:57:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-it0-f51.google.com Received: from mail-it0-f51.google.com (HELO mail-it0-f51.google.com) (209.85.214.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 10:57:57 +0000 Received: by mail-it0-f51.google.com with SMTP id m84so13248169ita.0 for ; Tue, 27 Jun 2017 03:57:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ybDpFBmJuHeqJ8IErL/nKJAXKbAdIVRLWaR7Uq2ZDmE=; b=axN2rjnUC6IKlyRGyAWM2ZYASYg8OtO/J5IrEfvB3ETe5YPFXYsQtj9poce9J+ClGQ bQxRJg5ABr+ZEobxeDclvXivYZEpx7QQ6/BhUpVMqoaA3N7Qn4UV5ASwXAyne1aNU7v3 DLxHs/GFQWWWvXhWqzJ9F+TW1zFjvOW4+y1xVkCexqSC1ir8+oxQB1L2L5aYW++zHEOk EhEjChaUcvu+xG45ruj0sNH6YOUXJZGL+F2g69vPUM6isLswVBI2rg8YzNz7HygijubD 9Ozaptni4zpuVJifB6rGsSdw9L0Mq4at/SnWQAn4kqqpNwjWFG/MhsxmQ1PTLY2AM29Y WHSw== X-Gm-Message-State: AKS2vOw39pjH/WUXhgof5y43gsvWK0Q9+n8DHads10rvXqh9k9Z0dVAA pNhlr4LbERK0bQ== X-Received: by 10.36.2.133 with SMTP id 127mr2569910itu.21.1498561075996; Tue, 27 Jun 2017 03:57:55 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id w199sm1359848iod.15.2017.06.27.03.57.54 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 27 Jun 2017 03:57:55 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , "vapier\@gentoo.org" , nd Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from remote-sim.c References: <86wpbft0r4.fsf@gmail.com> <692B46FA-E9FE-48BF-BE1C-9DDD606474B7@arm.com> Date: Tue, 27 Jun 2017 10:57:00 -0000 In-Reply-To: <692B46FA-E9FE-48BF-BE1C-9DDD606474B7@arm.com> (Alan Hayward's message of "Mon, 26 Jun 2017 12:41:18 +0000") Message-ID: <86fuelg0k1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00719.txt.bz2 Alan Hayward writes: Patch is good to me. > if (nr_bytes > 0 > - && nr_bytes !=3D register_size (gdbarch, regno) && warn_user) > + && nr_bytes !=3D regsize && warn_user) > { A nit, can you put them in a single line? --=20 Yao (=E9=BD=90=E5=B0=A7)