From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100912 invoked by alias); 25 Jul 2017 16:44:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100881 invoked by uid 89); 25 Jul 2017 16:44:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=iow, Hx-spam-relays-external:209.85.223.194, H*RU:209.85.223.194, H*r:sk:static. X-HELO: mail-io0-f194.google.com Received: from mail-io0-f194.google.com (HELO mail-io0-f194.google.com) (209.85.223.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Jul 2017 16:44:45 +0000 Received: by mail-io0-f194.google.com with SMTP id c74so1176678iod.4 for ; Tue, 25 Jul 2017 09:44:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=JbC+FGvrh5bUMvfdZcYa0fZktbmjm9+BFxrVuE845vs=; b=bdG0f5FB27r4jw0a5uUVqlMshTPKcI51wbz77iEwxUZ4aVE4XnjQRgDfHMEtmZdZwU wVTRdHhR5rEZKwFF6r+GLsg43ZG/Pe9wNtRG/NEzj36rki4pX2I0wNHXsw/cUM8EDM3U wd5wkxXUu85XNuAnFGV/O+Go3xXmkPsgYlWOFafFgt3PY9PPLACW6FNpONGmucKaE31E OVIgsTmRaFJqeawSPzQBto+gftM1yg6BOtCMP/n2jX6L4OK7oYLQgFKkb87O7POhpGBs TeyVixUtjOiJLFFcOsyEzVeal7Ai/5+xaeVoBivrA7givCf3nuBnTRvkdfg0J0GxgciD +d8A== X-Gm-Message-State: AIVw113vAsn8b5FPYvNkrwFfKHHoNn/dOpkKtj43P0wuZKol4A75IRBu ONGjqI4lL1fjLdOi X-Received: by 10.107.23.4 with SMTP id 4mr19117636iox.110.1501001083854; Tue, 25 Jul 2017 09:44:43 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id 70sm2343072iop.77.2017.07.25.09.44.42 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 25 Jul 2017 09:44:43 -0700 (PDT) From: Yao Qi To: jose.marchesi@oracle.com (Jose E. Marchesi) Cc: Weimin Pan , gdb-patches@sourceware.org Subject: Re: [PATCH v4] gdb: ADI support References: <1500424890-112103-1-git-send-email-weimin.pan@oracle.com> <86o9s8pmyg.fsf@gmail.com> <87a83sleio.fsf@oracle.com> Date: Tue, 25 Jul 2017 16:44:00 -0000 In-Reply-To: <87a83sleio.fsf@oracle.com> (Jose E. Marchesi's message of "Tue, 25 Jul 2017 17:31:11 +0200") Message-ID: <86fudkpitj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00369.txt.bz2 jose.marchesi@oracle.com (Jose E. Marchesi) writes: > General question: what's wrong with using a simple linked list of > structs if that is the developer's preference, and/or it follows the > current style of the surrounding code? (Not saying it is in this case, > that's up to Weimin to say.) It makes the code a little bit unnecessarily complicated, IOW, std::list or std::forward_list can make it simpler. My preference is to use standard c++ data structure rather than re-inventing it again. > > As far as I can see the usage of STL is not mandated by the GDB coding > standards (as documented in the wiki) and developers may want to avoid > them in many circumstances. It is out of the scope of coding standard. GDB is a C++ project, when we organize something as a list, it is quite natural to use standard c++ data structure. --=20 Yao (=E9=BD=90=E5=B0=A7)