From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130426 invoked by alias); 12 Feb 2016 15:14:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130414 invoked by uid 89); 12 Feb 2016 15:14:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pf0-f195.google.com Received: from mail-pf0-f195.google.com (HELO mail-pf0-f195.google.com) (209.85.192.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 12 Feb 2016 15:14:07 +0000 Received: by mail-pf0-f195.google.com with SMTP id 71so4102426pfv.1 for ; Fri, 12 Feb 2016 07:14:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=Ea66hH+tBwkURburjsUj0Phgc1MTvZyFMARju9mDn+8=; b=S6lbByIsch/ROXOlmLpGpJIia1u1Y/WgV2bjqmd1iPxcIy5q6rlPM8IiIg2pIX+hBh M154r+C/5Zd+jnyloHtKsiQ0O0bRhwflEL5aFaOxRARtVTs3P3ibZV0WC+mKzjLBUZfR XqVEL5Dh3eG7bHWSM4TDkPhbIHdw5x5L+tKcB0z+9CROZXuxM8ZzD1R0VwpsSZKEmk7S a5m2Xjk/tuHD5LFwhHs3QjgQYLJaSZVDJhW/Hm2Z4Ez+VoyDj6l/MVHTuhibu7JLI1/x 1xe4xn60M9JdvisEQAmXm/At/ixfU4uOrLiO98fVEZcTF67852LMMrZ+6O3NQWx14qYy IXnA== X-Gm-Message-State: AG10YOSVwCWr9Ma0HdJlXyZCPPNf4IaShCUiWTsaF+yQT8ZNC66ZmyfqPKPbGHLHE55MAQ== X-Received: by 10.98.19.215 with SMTP id 84mr2956060pft.22.1455290046289; Fri, 12 Feb 2016 07:14:06 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id g81sm20220125pfj.1.2016.02.12.07.14.01 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 12 Feb 2016 07:14:03 -0800 (PST) From: Yao Qi To: Antoine Tremblay Cc: Subject: Re: [PATCH 3/4] Enable tracing of pseudo-registers on ARM References: <1452188697-23870-1-git-send-email-antoine.tremblay@ericsson.com> <1452188697-23870-4-git-send-email-antoine.tremblay@ericsson.com> Date: Fri, 12 Feb 2016 15:14:00 -0000 In-Reply-To: <1452188697-23870-4-git-send-email-antoine.tremblay@ericsson.com> (Antoine Tremblay's message of "Thu, 7 Jan 2016 12:44:56 -0500") Message-ID: <86egcineq0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00411.txt.bz2 Antoine Tremblay writes: > +/* Map the pseudo register number REG to the proper register number. */ > + > +static int > +arm_pseudo_register_to_register (struct gdbarch *gdbarch, int reg) > +{ > + int rawnum =3D 0; > + int num_regs =3D gdbarch_num_regs (gdbarch); > + > + /* Single precision pseudo registers. s0-s31. */ > + if (reg >=3D num_regs && reg < num_regs + 32) > + { > + rawnum =3D (reg - num_regs) / 2 + 26; We should get double register number via user_reg_map_name_to_regnum, xsnprintf (name_buf, sizeof (name_buf), "d%d", (reg - num_regs) / 2); double_regnum =3D user_reg_map_name_to_regnum (gdbarch, name_buf, strlen (name_buf)); > + } > + /* Quadruple precision pseudo regisers. q0-q15. */ > + else if (reg >=3D num_regs + 32 && reg < num_regs + 32 + 16) > + { > + rawnum =3D (reg - num_regs - 32) * 2 + 26; Likewise, xsnprintf (name_buf, sizeof (name_buf), "d%d", (reg - num_regs) * 2); double_regnum =3D user_reg_map_name_to_regnum (gdbarch, name_buf, strlen (name_buf)); additionally, we need to check gdbarch_tdep (gdbarch)->have_neon_pseudos, > + } > + /* Error bad register number. */ > + else > + return -1; > + > + return rawnum; > +} We also need a test case, and you can extend gdb.trace/tfile-avx.exp. Probably, it can be renamed to gdb.trace/tracefile-pseudo-reg.exp, and put x86 and arm tests in it. --=20 Yao (=E9=BD=90=E5=B0=A7)