From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87520 invoked by alias); 10 May 2016 15:12:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86916 invoked by uid 89); 10 May 2016 15:12:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=sk:ARM_SYM, sk:st_bran, sk:arm_elf, sk:ST_BRAN X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 10 May 2016 15:11:57 +0000 Received: by mail-pa0-f50.google.com with SMTP id bt5so6463223pac.3 for ; Tue, 10 May 2016 08:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hbCEe2VSxEufWmAZAx6JxmxkEZb+pF4dDTl0N7BvKEI=; b=W6ccX70XNW74uAg7JiHYhYXUiNec4YDDwQF4483oIlNlIUI4K0qn8LY1oX2u6uJfGt A++3xgI3XBAfYaxlUv5lC+vtLkXfBgf0koEf4a7gP3D8PICzxFAaaB/mxi8N9/Ws8X/8 +c0DiPf3RvBXtTnfo+uDgXYKO7ePNrrh77iKoTSw+EPvziK5+8IWSS0QMpt1QYCQViIx b/yCyqZQYz0XtoNhJd/7MwsdWjxZD1txB5ovS+Axx3s6SuTTzBhS4hKNHyG3l621up2P m2YUuIH5JKiAbMHUw1Sh1UWlXxjZextphR/7a7lw/BlvPT1Xj8MgtjxnodH0XtocN3u+ THcQ== X-Gm-Message-State: AOPr4FWvBzGy5bEAg7l5fiWlt7fyNOsfCVj4Je7e9pexh0aOe4saiQVggpGURUis6Cr4mg== X-Received: by 10.66.177.75 with SMTP id co11mr59890380pac.85.1462893115761; Tue, 10 May 2016 08:11:55 -0700 (PDT) Received: from E107787-LIN (gcc113.osuosl.org. [140.211.9.71]) by smtp.gmail.com with ESMTPSA id h16sm5319616pfj.0.2016.05.10.08.11.53 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 10 May 2016 08:11:54 -0700 (PDT) From: Yao Qi To: Thomas Preudhomme Cc: gdb-patches@sourceware.org Subject: Re: [PATCH, gdb, ARM] Use getters/setters to access ARM branch type References: <3219422.otqiV2U3aN@e108577-lin> Date: Tue, 10 May 2016 15:12:00 -0000 In-Reply-To: <3219422.otqiV2U3aN@e108577-lin> (Thomas Preudhomme's message of "Tue, 10 May 2016 15:39:54 +0100") Message-ID: <86eg9adk20.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00173.txt.bz2 Thomas Preudhomme writes: > @@ -8467,7 +8467,8 @@ coff_sym_is_thumb (int val) > static void > arm_elf_make_msymbol_special(asymbol *sym, struct minimal_symbol *msym) > { > - if (ARM_SYM_BRANCH_TYPE (&((elf_symbol_type *)sym)->internal_elf_sym) > + elf_symbol_type *elfsym =3D (elf_symbol_type *) sym; We need a blank line here. > + if (ARM_GET_SYM_BRANCH_TYPE (elfsym->internal_elf_sym.st_target_intern= al) > =3D=3D ST_BRANCH_TO_THUMB) > MSYMBOL_SET_SPECIAL (msym); Patch is OK to me. --=20 Yao (=E9=BD=90=E5=B0=A7)