From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90511 invoked by alias); 21 Apr 2017 18:08:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90413 invoked by uid 89); 21 Apr 2017 18:08:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:539 X-HELO: mail-wr0-f195.google.com Received: from mail-wr0-f195.google.com (HELO mail-wr0-f195.google.com) (209.85.128.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Apr 2017 18:08:03 +0000 Received: by mail-wr0-f195.google.com with SMTP id w50so8496131wrc.0 for ; Fri, 21 Apr 2017 11:08:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=qpGQawP0Wnm3rDQ8/CX5QEWVRaSps8Bdmx5r6UNtjeo=; b=jmn95oygbdp9sxzLollCw3r1qxrDN4jXIFhqHpCqu3b7710VXUj94P9DbOnTL/bcCn uORtTND+daJxuN3fdJE7Yc/txfFXn3+kUPssgELbr+4GycAHcnsASGdPIJCePpVElAMw /JU0ofDzRpHDsszKamgyATdqjicd4F60ihvtyMYkvC1YKqrM82J+MZx6+L3WzgOdejCE mnj8IyDCgbCA9bE2LFX3x5845hnbU7r8vDyfenhY9Lw+T/Orbor6y0qVr4hdDaES0/N5 Zn64Wbr8Adu+VbnBAH8xOrGiBtitE2s4OazY24L1sK+5Ls1LY3opRrarSxaNCET/l/Yr Af0g== X-Gm-Message-State: AN3rC/5pgJx7nr7wSHlg8DaeXGncnnv/2NZQMpiHiN0vtgsCtJO6waYK m12D3Ma11tFqLKfH X-Received: by 10.223.152.6 with SMTP id v6mr1485193wrb.60.1492792221299; Fri, 21 Apr 2017 09:30:21 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id j32sm12183140wre.67.2017.04.21.09.30.20 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 21 Apr 2017 09:30:20 -0700 (PDT) From: Yao Qi To: Tim Wiederhake Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, brobecker@adacore.com, pmuldoon@redhat.com, dje@google.com Subject: Re: [PATCH v2 2/8] Python: Fix exception handling in py-record-btrace.c References: <1492771786-26372-1-git-send-email-tim.wiederhake@intel.com> <1492771786-26372-3-git-send-email-tim.wiederhake@intel.com> Date: Fri, 21 Apr 2017 18:08:00 -0000 In-Reply-To: <1492771786-26372-3-git-send-email-tim.wiederhake@intel.com> (Tim Wiederhake's message of "Fri, 21 Apr 2017 12:49:40 +0200") Message-ID: <86efwlzpt2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00615.txt.bz2 Tim Wiederhake writes: > GDB_PY_HANDLE_EXCEPTION does not handle all exceptions. Replace with cal= l to > gdbpy_convert_exception. > > 2017-04-21 Tim Wiederhake > > gdb/ChangeLog: > python/py-record-btrace.c (btpy_insn_sal, btpy_insn_data, > btpy_insn_decode, recpy_bt_goto): Handle all exceptions. I don't know much about exception in python, could some one else review this patch? Phil, Doug? --=20 Yao (=E9=BD=90=E5=B0=A7)