From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +jVmKfawsmia6Q8AWB0awg (envelope-from ) for ; Sat, 30 Aug 2025 04:06:14 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=LjeCOns5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 945161E04C; Sat, 30 Aug 2025 04:06:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 54DE91E043 for ; Sat, 30 Aug 2025 04:06:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 663D63858431 for ; Sat, 30 Aug 2025 08:06:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 663D63858431 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=LjeCOns5 Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 0334A3858CD1 for ; Sat, 30 Aug 2025 08:05:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0334A3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0334A3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756541142; cv=none; b=D5qe6hqsZeeum9oyD/vDQhrsa9iwqI3tx3bxP213NdvZ7uLWGbJZfDocUVUoT3F4mFnxCfaemkL+krhIUGbvALGItB5DUxZjtHa3c84Is2vrs32FsQIDx+yNYSu63jgaKRl9JPunYKzQg2wzrSADS3a3MSw1v0zTL/cW/0kNf34= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756541142; c=relaxed/simple; bh=shFDCD3zxObOkJqxvXP0LhqsWCPmmt4JvKtG77wAESU=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=P1/q0hkFszMk+8nYlYzISg0usIhRrB8aR8PsQ/7e5i5FDNyYSiQYkuIXmhF4S+FspRDahKPydxLsqeIQbYPDPoEpBDxR9XsE0zJ4lOE6nleSqEmtzX05wO+iaXO/O026YUfbj9hWMK/I3SFMkp/M3Fyt6JuF5JM2zMPha96Lqts= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0334A3858CD1 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1usGai-0007dz-Vl; Sat, 30 Aug 2025 04:05:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8WYzqqDeVMMWJmPITtdik6ZYX3L6SLQyJK4kXOuYyBY=; b=LjeCOns5N2zh 5UfUnS0jkp0xtpxDWrDqOvxpzrg6TB6yAfQ/bGhbIYaCfztyi7IwwSRY1/KsdEG/O36YIFrtNlKO9 pYUWdGjPy/94GgVsZVhGiujIdUolyovio79L97O3a2HJmNZnuJdTSbFi++bBnzdbIuiyi9qDQq7Uf AxBD0/I2s13apAA9pNVNEvWIzI/+F4QE4+vQlFsEwrHMsT+762x3pH3cHXTvgWzdqHLOeWqEFe80A jGkOubYLYTF16Fe82CEJaoQBabCpnV3UuCzgHQ5e3qkTIGXQtF7/QegT9CUXfxih15m8DR9Jygp17 jhSUlTIldNg/3BHf2cwH6w==; Date: Sat, 30 Aug 2025 11:05:38 +0300 Message-Id: <86ecstqlnx.fsf@gnu.org> From: Eli Zaretskii To: gdb-patches@sourceware.org Cc: aargri@gmail.com In-Reply-To: <86y0riimy3.fsf@gnu.org> (message from Eli Zaretskii on Sun, 17 Aug 2025 07:36:36 +0300) Subject: Re: [PATCH] gdb/doc: qSearch:memory packets use escaped binary patterns References: <20250816-qsearch-doc-binary-v1-1-55e8f1864ddd@gmail.com> <86y0riimy3.fsf@gnu.org> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > Date: Sun, 17 Aug 2025 07:36:36 +0300 > From: Eli Zaretskii > Cc: gdb-patches@sourceware.org > > > From: Aaron Griffith > > Date: Sat, 16 Aug 2025 16:52:54 -0400 > > > > The `qSearch:memory` packet uses hex encoding for the address and > > length arguments, but the search-pattern argument uses escaped binary. > > > > --- > > This documentation change can be confirmed two ways: > > > > * Inspect the packets sent by gdb with `set debug remote`, and then > > search memory with e.g. `find &buf[0], +sizeof(buf), "foo"`. > > > > * The implementation `search_memory` in gdb/remote.c uses > > `remote_escape_output` for the pattern argument, and this function > > is documented as encoding escaped binary data. > > --- > > gdb/doc/gdb.texinfo | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > > index d4a5a632c24306f6c0ff6bd6d14e01a847e9a494..0ae15642c0d1b92f08bbd16011cf0214deec6dfa 100644 > > --- a/gdb/doc/gdb.texinfo > > +++ b/gdb/doc/gdb.texinfo > > @@ -44887,7 +44887,8 @@ packets.) > > @anchor{qSearch memory} > > Search @var{length} bytes at @var{address} for @var{search-pattern}. > > Both @var{address} and @var{length} are encoded in hex; > > -@var{search-pattern} is a sequence of bytes, also hex encoded. > > +@var{search-pattern} is a sequence of binary-encoded bytes > > +(@pxref{Binary Data}). > > > > Reply: > > @table @samp > > Thanks, this is okay, as far as the Texinfo markup and the language > are concerned (I have no knowledge about the actual issue, but I > expect others to comment if they disagree). > > Approved-By: Eli Zaretskii Any objections to me installing these changes, anyone?