Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support

Edjunior Barbosa Machado
2015-05-27T14:12:29Z

On 05/27/2015 07:21 AM, Yao Qi wrote:
> Yao Qi <qiyaoltc@gmail.com> writes:
>
>>> gcc -g -O2 -mminimal-toc -I. -I../../gdb -I../../gdb/common -I../../gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../../gdb/../zlib -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../gdb/../libdecnumber -I../../gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o aarch64-tdep.o -MT aarch64-tdep.o -MMD -MP -MF .deps/aarch64-tdep.Tpo ../../gdb/aarch64-tdep.c
>>> ../../gdb/aarch64-tdep.c: In function ‘aarch64_process_record’:
>>> ../../gdb/aarch64-tdep.c:2823:23: error: ‘record_buf[0]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>> memcpy(&REGS[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
>>> ^
>>> ../../gdb/aarch64-tdep.c:3529:12: note: ‘record_buf[0]’ was declared here
>>> uint32_t record_buf[2];
>>> ^
>>>
>>> The simple patch below intends to fix this. Ok?
>>
>> This build error reveals some logic error inside function
>> aarch64_record_data_proc_simd_fp on decoding instructions. I'll take a look.
>
> Here is the patch below, it fixes the build failure on my machine. Does
> it work for you too?
>

Hi Yao,
unfortunately I was unable to apply your patch due to the follow:

$ patch -p1 -i ~/fix.patch --dry
(Stripping trailing CRs from patch; use --binary to disable.)
checking file gdb/aarch64-tdep.c
patch: **** malformed patch at line 6: *aarch64_insn_r)

--
Edjunior