From: Yao Qi <qiyaoltc@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [obv] compile-print.exp: xfail->kfail for '@' GDB array operator
Date: Fri, 05 Jun 2015 09:35:00 -0000 [thread overview]
Message-ID: <86d21ao5vw.fsf@gmail.com> (raw)
In-Reply-To: <20150604193820.GA18453@host1.jankratochvil.net> (Jan Kratochvil's message of "Thu, 4 Jun 2015 21:38:20 +0200")
Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Hi, Jan,
This patch isn't obvious to me... see my question below,
> Patch implementing '@' GDB array operator in GCC has been rejected:
> https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00414.html
> and so there is now a GDB tracker to implement it just in GDB:
> https://sourceware.org/bugzilla/show_bug.cgi?id=18489
If '@' is rejected in GCC, why do we need to support it in "compile"
feature in GDB? The manual of command "compile print" says:
Compile and execute expr with the compiler language found as the
current language in GDB
'@' isn't a valid operator for C language, we should emit error here.
IMO, "compile" feature should *only* accept valid source code according
to the language spec and the compiler. It will be really confusing if
we add some other things (like '@' in this case) which is out of the
scope of the language.
> @@ -38,7 +38,7 @@ gdb_test_multiple $test $test {
> pass $test
> }
> -re ": error: stray '@' in program\r\n.*\r\n$gdb_prompt $" {
> - xfail "$test (gcc does not support '@')"
> + kfail compile/18489 "$test"
> }
> }
I think xfail is correct as gcc doesn't support '@'.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-06-05 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 19:38 Jan Kratochvil
2015-06-05 9:35 ` Yao Qi [this message]
2015-06-05 12:40 ` Jan Kratochvil
2015-06-05 15:19 ` Doug Evans
2015-06-05 15:26 ` Jan Kratochvil
2015-06-05 16:13 ` Yao Qi
2015-06-05 21:23 ` Jan Kratochvil
2015-06-05 13:24 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d21ao5vw.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox