From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87295 invoked by alias); 8 Jul 2015 16:39:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86857 invoked by uid 89); 8 Jul 2015 16:39:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mail-pd0-f181.google.com Received: from mail-pd0-f181.google.com (HELO mail-pd0-f181.google.com) (209.85.192.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Jul 2015 16:39:07 +0000 Received: by pdbep18 with SMTP id ep18so148400442pdb.1 for ; Wed, 08 Jul 2015 09:39:04 -0700 (PDT) X-Received: by 10.70.87.231 with SMTP id bb7mr22302865pdb.70.1436373544672; Wed, 08 Jul 2015 09:39:04 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id ob15sm3050303pdb.40.2015.07.08.09.39.03 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 08 Jul 2015 09:39:04 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 7/8] [testsuite][AArch64] Port gdb.trace References: <1436273518-5959-1-git-send-email-pierre.langlois@arm.com> <1436273518-5959-8-git-send-email-pierre.langlois@arm.com> Date: Wed, 08 Jul 2015 16:39:00 -0000 In-Reply-To: <1436273518-5959-8-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Tue, 7 Jul 2015 13:51:57 +0100") Message-ID: <86d202mwnv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00235.txt.bz2 Pierre Langlois writes: > +} elseif [istarget "aarch64*"] { > + set fpreg "\$x29" > + set spreg "\$sp" We need to check is_aarch64_target instead of istarget "aarch64*", considering the WIP aarch64 multi-arch debugging work. Please replace istarget "aarch64*" with is_aarch64_target in your patch. OK with the change. --=20 Yao (=E9=BD=90=E5=B0=A7)