From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40312 invoked by alias); 15 Sep 2015 10:06:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40299 invoked by uid 89); 15 Sep 2015 10:06:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f182.google.com Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Sep 2015 10:06:38 +0000 Received: by wiclk2 with SMTP id lk2so19880085wic.1 for ; Tue, 15 Sep 2015 03:06:34 -0700 (PDT) X-Received: by 10.180.86.100 with SMTP id o4mr5538133wiz.59.1442311594615; Tue, 15 Sep 2015 03:06:34 -0700 (PDT) Received: from E107787-LIN ([195.154.84.196]) by smtp.gmail.com with ESMTPSA id yu7sm20185238wjc.43.2015.09.15.03.06.33 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Tue, 15 Sep 2015 03:06:34 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/8] [AArch64] Use debug_printf instead of fprintf_unfiltered References: <1442230282-20751-1-git-send-email-pierre.langlois@arm.com> <1442230282-20751-2-git-send-email-pierre.langlois@arm.com> Date: Tue, 15 Sep 2015 10:06:00 -0000 In-Reply-To: <1442230282-20751-2-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Mon, 14 Sep 2015 12:31:15 +0100") Message-ID: <86d1xk3skc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00308.txt.bz2 Pierre Langlois writes: > @@ -3363,8 +3337,7 @@ aarch64_record_load_store (insn_decode_record *aarc= h64_insn_r) > { > if (record_debug) > { > - fprintf_unfiltered (gdb_stdlog, > - "Process record: load/store exclusive\n"); > + debug_printf ("Process record: load/store exclusive\n"); > } After your change, it becomes an one-line statement, so "{" and "}" are no longer needed. We can remove them too. Here, and somewhere else. OK with the changes. --=20 Yao (=E9=BD=90=E5=B0=A7)