From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121740 invoked by alias); 11 Feb 2016 11:58:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121725 invoked by uid 89); 11 Feb 2016 11:58:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:209.85.192.196, H*RU:209.85.192.196 X-HELO: mail-pf0-f196.google.com Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Feb 2016 11:58:40 +0000 Received: by mail-pf0-f196.google.com with SMTP id c10so2475673pfc.0 for ; Thu, 11 Feb 2016 03:58:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=hiyD7Q8eIgajdi72109Hkxeb29dQI02UUTL/ZHvT5o4=; b=CNW5eYYF+lkRRJTwgupcWIGadSn63QPwaKIVQaNUtfxCoTKHjBTx1Gqw03p8v8nNy5 1UOH4M8bwbrQ7FNgqcMtlqpk0Vj/toWzscmdEyjIcTNSx3+51Ecga9qzVRaeIpOpWKYG X5kGwq2U2Y0745fjVqhCMuLM/Qu1z0QrUIYLZ9qGqJ8uxdBSPCpdXM1sJPajv553LfT3 fA7o6W2/bDOrWV5w1dtLsdTLqbNMd/vzgcoVqtAi5vkXE79bB3cn+N41SWnTmr/xGmWS ZS5OIqTBNxL2ulJKGduKNxTBIEdnLxLPHkWR3QaBVN9CmVrpI4EvumQvHUQvhL0SFlpd xAhQ== X-Gm-Message-State: AG10YOTQhTRA/ImT3E2VBXV3c3zJItLMQ20hDU0Jr7+fvrW4b9HcHK3SErkiFv8q3wDYfQ== X-Received: by 10.98.64.202 with SMTP id f71mr66060738pfd.113.1455191918500; Thu, 11 Feb 2016 03:58:38 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 6sm11919337pfo.58.2016.02.11.03.58.36 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 11 Feb 2016 03:58:38 -0800 (PST) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH 3/3] arm-tdep.c: Refactor arm_decode_media References: <1455121027-27061-1-git-send-email-simon.marchi@ericsson.com> <1455121027-27061-4-git-send-email-simon.marchi@ericsson.com> Date: Thu, 11 Feb 2016 11:58:00 -0000 In-Reply-To: <1455121027-27061-4-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 10 Feb 2016 11:17:07 -0500") Message-ID: <86d1s3pifp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00342.txt.bz2 Simon Marchi writes: > - switch (bits (insn, 20, 24)) > + uint8_t op1 =3D bits (insn, 20, 24); > + uint8_t rd =3D bits (insn, 12, 15); > + uint8_t op2 =3D bits (insn, 5, 7); > + uint8_t rn =3D bits (insn, 0, 3); > + > + switch (op1) op1 is only used once, I prefer using bits (insn, 20, 24) rather than defining a new variable. Other variables, like rd and rn, can be defined where they are used. --=20 Yao (=E9=BD=90=E5=B0=A7)